linux-kernel - [PATCH net] net: mdio: aspeed: add dummy read to avoid read-after-write issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134A0B82901A8BAC9AAF4AB9DA3A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 9 Dec 2025 11:08:34 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Heiner Kallweit <hkallweit1@...il.com>, Russell King
	<linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Potin Lai <potin.lai@...ntatw.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: [PATCH net] net: mdio: aspeed: add dummy read to avoid
 read-after-write issue

Hi Andrew,

Thank you for your reply.

> >
> > Fixes: 737ca352569e ("net: mdio: aspeed: move reg accessing part into
> > separate functions")
> 
> That seems like an odd Fixes: tag. That is just moving code around, but the
> write followed by a read existed before that. Why not:
> 

Agreed.
I mistakenly thought I should reference the most recent integrated changes 
for the Fixes: tag.
I'll correct the Fixes: tag in the next revision.

> commit f160e99462c68ab5b9e2b9097a4867459730b49a
> Author: Andrew Jeffery <andrew@...id.au>
> Date:   Wed Jul 31 15:09:57 2019 +0930
> 
>     net: phy: Add mdio-aspeed
> 
>     The AST2600 design separates the MDIO controllers from the MAC, which
> is
>     where they were placed in the AST2400 and AST2500. Further, the register
>     interface is reworked again, so now we have three possible different
>     interface implementations, however this driver only supports the
>     interface provided by the AST2600. The AST2400 and AST2500 will
> continue
>     to be supported by the MDIO support embedded in the FTGMAC100
> driver.
> 
>     The hardware supports both C22 and C45 mode, but for the moment only
> C22
>     support is implemented.
> 
>     Signed-off-by: Andrew Jeffery <andrew@...id.au>
>     Reviewed-by: Andrew Lunn <andrew@...n.ch>
>     Signed-off-by: David S. Miller <davem@...emloft.net>

Thanks,
Jacky