linux-kernel - Re: [PATCH v3 RESEND] perf/core: Fix missing read event generation on task exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTgGlzb3VKvNtE9Z@gmail.com>
Date: Tue, 9 Dec 2025 12:23:03 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Thaumy Cheng <thaumy.love@...il.com>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 RESEND] perf/core: Fix missing read event generation
 on task exit

* Peter Zijlstra <peterz@...radead.org> wrote:

> >
> > -static void sync_child_event(struct perf_event *child_event);
> > +static void sync_child_event(struct perf_event *child_event,
> > +			     struct task_struct *task);
>
> This forward declaration can be entirely removed now.

Indeed - I've applied the delta patch below.

>
> Other than that, yes this seems fine. I see Ingo already picked up the
> patch, thanks!

and I've added your Acked-by as well.

Thanks,

	Ingo

================>
 kernel/events/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 47d5dc4bf700..dad0d3d2e85f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2317,9 +2317,6 @@ static void perf_group_detach(struct perf_event *event)
 	perf_event__header_size(leader);
 }
 
-static void sync_child_event(struct perf_event *child_event,
-			     struct task_struct *task);
-
 static void perf_child_detach(struct perf_event *event)
 {
 	struct perf_event *parent_event = event->parent;