linux-kernel - Re: [PATCH] af_unix: annotate unix_gc_lock with __cacheline_aligned_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176528101552.3919807.12895158051021890888.git-patchwork-notify@kernel.org>
Date: Tue, 09 Dec 2025 11:50:15 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Mateusz Guzik <mjguzik@...il.com>
Cc: kuniyu@...gle.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 kuba@...nel.org, oliver.sang@...el.com
Subject: Re: [PATCH] af_unix: annotate unix_gc_lock with
 __cacheline_aligned_in_smp

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  3 Dec 2025 11:01:22 +0100 you wrote:
> Otherwise the lock is susceptible to ever-changing false-sharing due to
> unrelated changes. This in particular popped up here where an unrelated
> change improved performance:
> https://lore.kernel.org/oe-lkp/202511281306.51105b46-lkp@intel.com/
> 
> Stabilize it with an explicit annotation which also has a side effect
> of furher improving scalability:
> > in our oiginal report, 284922f4c5 has a 6.1% performance improvement comparing
> > to parent 17d85f33a8.
> > we applied your patch directly upon 284922f4c5. as below, now by
> > "284922f4c5 + your patch"
> > we observe a 12.8% performance improvements (still comparing to 17d85f33a8).
> 
> [...]

Here is the summary with links:
  - af_unix: annotate unix_gc_lock with __cacheline_aligned_in_smp
    https://git.kernel.org/netdev/net/c/2183a5c8a04f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html