linux-kernel - Re: [PATCH] bus: fsl-mc: Cope for unbound devices in fsl_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c51882f6-500d-481f-adf3-c257fb7ea47a@kernel.org>
Date: Tue, 9 Dec 2025 13:05:50 +0100
From: "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Ioana Ciornei <ioana.ciornei@....com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: fsl-mc: Cope for unbound devices in fsl_mc_shutdown



Le 09/12/2025 à 12:59, Uwe Kleine-König a écrit :
> Other than a driver's shutdown callback the bus shutdown callback is
> also called for unbound drivers. So check for the device being bound
> before following the pointer to its driver.
> 
> Fixes: ef980bda574d ("bus: fsl-mc: Convert to bus callbacks")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> I pointed out this issue a few days ago in the thread that resulted in
> commit ef980bda574d, but didn't receive a reaction so far. Given that
> ef980bda574d is contained in next, I guess it's time for a proper patch
> to fix the issue. Here it is.

Thanks for the fixup.

Nobody reacted against what you pointed out a few days ago so I guess 
this fix is OK.

Unless you mind I will squash it into previous patch to avoid having to 
manage the Fixes: tag update when I rebase to 6.19rc1

Christophe

> 
> Best regards
> Uwe
> 
>   drivers/bus/fsl-mc/fsl-mc-bus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
> index 6bc163d2ca49..c08c04047ae2 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -162,7 +162,7 @@ static void fsl_mc_shutdown(struct device *dev)
>   	struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(dev->driver);
>   	struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
>   
> -	if (mc_drv->shutdown)
> +	if (dev->driver && mc_drv->shutdown)
>   		mc_drv->shutdown(mc_dev);
>   }
>   
> 
> base-commit: ef980bda574d3a2ebaa297def62f03d2222e6ef3