linux-kernel - Re: [PATCH v9 13/16] arm64: entry: Convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec404a91-2e24-4198-975b-e26c6a8330f8@arm.com>
Date: Tue, 9 Dec 2025 14:47:35 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Jinjie Ruan <ruanjinjie@...wei.com>, catalin.marinas@....com,
 will@...nel.org, oleg@...hat.com, tglx@...utronix.de, peterz@...radead.org,
 luto@...nel.org, shuah@...nel.org, kees@...nel.org, wad@...omium.org,
 deller@....de, macro@...am.me.uk, charlie@...osinc.com, ldv@...ace.io,
 mark.rutland@....com, song@...nel.org, ryan.roberts@....com,
 ada.coupriediaz@....com, anshuman.khandual@....com, broonie@...nel.org,
 pengcan@...inos.cn, dvyukov@...gle.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v9 13/16] arm64: entry: Convert to generic entry

On 04/12/2025 09:21, Jinjie Ruan wrote:
> Currently, x86, Riscv, Loongarch use the generic entry which makes
> maintainers' work easier and codes more elegant. arm64 has already
> switched to the generic IRQ entry, so completely convert arm64 to use
> the generic entry infrastructure from kernel/entry/*.
>
> The changes are below:
>  - Remove TIF_SYSCALL_* flag.
>
>  - Remove _TIF_SYSCALL_WORK and has_syscall_work(), as _TIF_SYSCALL_WORK
>    is equal with SYSCALL_WORK_ENTER.

Should be updated considering patch 7 (has_syscall_work() no longer
exists and there is also _TIF_SYSCALL_EXIT_WORK).

>  - Implement arch_ptrace_report_syscall_entry/exit() with
>    report_syscall_entry/exit() to do arm64-specific save/restore
>    during syscall entry/exit.
>
>  - Add "ARCH_SYSCALL_WORK_EXIT" to be defined as "_TIF_SECCOMP |
>    _TIF_SYSCALL_EMU" to keep the arm64 behaviour unchanged.

No longer the case.

>  - Remove arm64 syscall_trace_enter(), syscall_exit_to_user_mode_prepare(),
>    and related sub-functions including syscall_exit_work() and
>    syscall_enter_audit(), by calling generic entry's functions with similar
>    functionality.

Would be good to talk about SYSCALL_EXIT_TRAP as well.

Otherwise:

Reviewed-by: Kevin Brodsky <kevin.brodsky@....com>

> - Implement arch_syscall_is_vdso_sigreturn() to support "Syscall User
>   Dispatch".
>
> Suggested-by: Kevin Brodsky <kevin.brodsky@....com>
> Suggested-by: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
>
> [...]