linux-kernel - Re: [PATCH v4 2/3] iio: adc: ad9467: sort header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeOZHvxr60R0TCS5_c-xsrmfC97gWdP4-EWvFPpbodLTA@mail.gmail.com>
Date: Tue, 9 Dec 2025 16:41:22 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Tomas Melin <tomas.melin@...sala.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Nuno Sa <nuno.sa@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] iio: adc: ad9467: sort header includes

On Tue, Dec 9, 2025 at 7:34 AM Tomas Melin <tomas.melin@...sala.com> wrote:
>
> Include headers in ascending order.

Thanks, but...

>  #include <linux/iio/backend.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>

...this was specifically grouped to show the relation to the certain
subsystem. At the end we should have something like this

linux/*.h // generic ones
...blank line...
asm/*.h // generic ones (optionally, if there is a need in a such)
...blank line...
linux/iio/*.h
...blank line...

So, what I meant with fixing clk.h is just to move it to the main
group and sort that.

You can check (recent enough) drivers for the examples. Yes, some of
them (but minority IIRC) might have linux/iio/*.h among linux/*.h, but
usually they are grouped separately.

-- 
With Best Regards,
Andy Shevchenko