linux-kernel - Re: [PATCH] leds: rgb: leds-ktd202x: Fix error code in ktd202x_setup_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vc4O-fzsAuSY_zmpXFROO1Qa+7WLUVPuZm9uxNj00kZ3g@mail.gmail.com>
Date: Tue, 9 Dec 2025 16:44:14 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Kate Hsuan <hpa@...hat.com>, Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
	Jonathan Cameron <jonathan.cameron@...wei.com>, Hans de Goede <hansg@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] leds: rgb: leds-ktd202x: Fix error code in ktd202x_setup_led_rgb()

On Tue, Dec 9, 2025 at 4:41 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
> On Tue, Dec 09, 2025 at 04:14:03PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 9, 2025 at 8:56 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:

...

> > >                 if (ret != 0 || reg >= chip->num_leds) {
> > >                         dev_err(chip->dev, "invalid 'reg' of %pfw\n", child);
> > >                         fwnode_handle_put(child);
> > > -                       return ret;
> > > +                       return ret ?: -EINVAL;
> > >                 }
> >
> > I think the better fix is to split the original conditional to two.
> >
> > And make the message something like
> > "can't retrieve 'reg' property of %pfw\n'
> > for the case if (ret).
>
> These are never going to show up for users, the messages are only for
> developers bringing up a board...

Even better,

  if (ret) {
    fwnode_handle_put(...);
    return ret;
  }

  if (reg >= ...) {
    ...
  }

Since it's a fix likely for a backporting, the separate change can
move to the _scoped() for_each loop and drop those fwnode_handle_put()
calls.

-- 
With Best Regards,
Andy Shevchenko