linux-kernel - Re: [PATCH v2] resource: add WARN_ON_ONCE for resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aThBpvAXlS7Jccja@smile.fi.intel.com>
Date: Tue, 9 Dec 2025 17:35:02 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v2] resource: add WARN_ON_ONCE for resource_size() and
 document misusage

On Tue, Dec 09, 2025 at 05:33:11PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 09, 2025 at 04:01:40PM +0100, Christian Marangi wrote:

...

> >  #ifndef __ASSEMBLY__
> >  #include <linux/bits.h>
> 
> > +#include <linux/bug.h>
> 
> Even though it's under non-assembly, please use asm/bug.h where the macro is
> defined. This is a wide used header and putting unrelated stuff into the chain
> is not good and tend to add tangled dependencies in the future (if not now).
> 
> >  #include <linux/compiler.h>
> >  #include <linux/minmax.h>
> >  #include <linux/types.h>

To avoid possible misinterpretation of my comment, this should look like

  #ifndef __ASSEMBLY__
  #include <linux/*.h> // all linux/*.h
  ...blank line...
  #include <asm/bug.h>

-- 
With Best Regards,
Andy Shevchenko