linux-kernel - Re: [PATCH] resource: add WARN_ON_ONCE for resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aThDBuWTGfAwO4C_@smile.fi.intel.com>
Date: Tue, 9 Dec 2025 17:40:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] resource: add WARN_ON_ONCE for resource_size() and
 document misusage

On Tue, Dec 09, 2025 at 04:09:57PM +0100, Christian Marangi wrote:
> On Tue, Dec 09, 2025 at 05:07:09PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 09, 2025 at 12:25:38PM +0200, Ilpo Järvinen wrote:
> > > On Mon, 8 Dec 2025, Christian Marangi wrote:

...

> > > >  static inline resource_size_t resource_size(const struct resource *res)
> > > >  {
> > > > +	WARN_ON_ONCE(!res->flags);
> > > 
> > > As lkp also found out, you need to add #include <linux/bug.h>
> > 
> > Since it's header, we may use better one from asm, i.e. asm/bug.h.
> > This will give finer granularity and less possible tangled dependencies
> > in the future.
> >
> 
> Will change in v3 I assume minor touch up to wording might be needed so
> it's not a problem.

Ah, I just commented on v2, yeah, please give at least 24h between versions of
the patch.

> > > >  	return res->end - res->start + 1;
> > > >  }

-- 
With Best Regards,
Andy Shevchenko