linux-kernel - Re: [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs for CAN XL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f33bb7a6-75c7-4ee4-baae-755ff25d81d6@hartkopp.net>
Date: Tue, 9 Dec 2025 17:17:38 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Rakuram Eswaran <rakuram.e96@...il.com>, linux-can@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, mailhol@...nel.org, mkl@...gutronix.de
Subject: Re: [RFC PATCH 0/2] can: add dummy_can termination and update
 SocketCAN docs for CAN XL

Hello Rakuram,

On 08.12.25 15:19, Rakuram Eswaran wrote:
> On Fri, 28 Nov 2025 at 00:49, Rakuram Eswaran <rakuram.e96@...il.com> wrote:
>>
>> This RFC series introduces two changes related to CAN XL support:
>>
>>    1. Add termination configuration support to the dummy_can driver,
>>       enabling termination testing with iproute2.
>>
>>    2. Update the SocketCAN documentation to describe CAN XL operation,
>>       including MTU changes, bittiming/XBTR settings, mixed-mode
>>       behaviour, error signalling, and example iproute2 usage.
>>
>> The goal of this RFC is to validate whether the proposed behaviour and
>> documentation match the expectations for the ongoing CAN XL upstream
>> work. Feedback from the maintainers is highly appreciated.
>>
>> Base commit:
>> commit 30f09200cc4a ("Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux")
>>
>> For testing, this series was applied on top of the following patchsets:
>>
>>    * "treewide: remove can_change_mtu()" (Vincent Mailhol)
>>          b4 am 20251003-remove-can_change_mtu-v1-1-337f8bc21181@...nel.org
>>          git am ./20251003_mailhol_can_treewide_remove_can_change_mtu.mbx
>>
>>    * "can: netlink: add CAN XL support" (Marc Kleine-Budde)
>>          b4 am 20251126-canxl-v8-0-e7e3eb74f889@...gutronix.de
>>          git am ./v8_20251126_mkl_can_netlink_add_can_xl_support.mbx
>>
>> Testing was performed using the iproute2-next tree (canxl-netlink branch),
>> which contains the required CAN XL netlink support for validating
>> these changes.
>>
> 
> Hello,
> 
> Gentle ping — any feedback on this documentation update patch series?

Many thanks for the patches.

The termination patch should be commented by Vincent, who is currently 
pretty busy.

But as the next merge windows is far away this can be managed in 
January. No hurry.

The documentation is almost fine but still has error-signalling in the 
ip options and there's definitely no xl-cc-len16-dlc option.

Please use the latest iproute2 code to generate the examples:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/

Best regards,
Oliver