linux-kernel - Re: [PATCH] arm64: dts: qcom: ipq9574: Use 'usb-phy' for node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23d3bc82-0909-42a4-b4a9-742834faec76@gmail.com>
Date: Tue, 9 Dec 2025 10:26:01 -0600
From: mr.nuke.me@...il.com
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: ipq9574: Use 'usb-phy' for node names

On 12/9/25 10:17 AM, Dmitry Baryshkov wrote:
> On Tue, Dec 09, 2025 at 10:07:54AM -0600, Alexandru Gagniuc wrote:
>> The devicetree spec allows node names of "usb-phy". So be more
>> specific for the USB PHYs, and name the nodes "usb-phy" instead of
>> just "phy".
> 
> Why? "phy" is more generic.

Hi Dmitry,

The goal is to be more specific. I find usb-phy, ethernet-phy and others
to me much clearer. As I see these more specific names being used throughut
dts files, I did not expect this to be controversial.

I am trying to follow devicetree v0.4, "2.2.2 Generic Names Recommendation",
which allows these more-specific node names.

Alex



> 
>>
>> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> index 86c9cb9fffc98..4b8cbf1ff131b 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> @@ -702,7 +702,7 @@ qpic_nand: spi@...0000 {
>>   			status = "disabled";
>>   		};
>>   
>> -		usb_0_qusbphy: phy@...00 {
>> +		usb_0_qusbphy: usb-phy@...00 {
>>   			compatible = "qcom,ipq9574-qusb2-phy";
>>   			reg = <0x0007b000 0x180>;
>>   			#phy-cells = <0>;
>> @@ -716,7 +716,7 @@ usb_0_qusbphy: phy@...00 {
>>   			status = "disabled";
>>   		};
>>   
>> -		usb_0_qmpphy: phy@...00 {
>> +		usb_0_qmpphy: usb-phy@...00 {
>>   			compatible = "qcom,ipq9574-qmp-usb3-phy";
>>   			reg = <0x0007d000 0xa00>;
>>   			#phy-cells = <0>;
>> -- 
>> 2.45.1
>>
> 
The