linux-kernel - Re: [PATCH] perf test: Fix test case perf evlist tests for s390x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fVxFEzOwQN610gE9F5XiHYP2wHKD6K5zfBHhFOrxD1fDw@mail.gmail.com>
Date: Tue, 9 Dec 2025 08:40:12 -0800
From: Ian Rogers <irogers@...gle.com>
To: Thomas Richter <tmricht@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, acme@...nel.org, namhyung@...nel.org, 
	agordeev@...ux.ibm.com, gor@...ux.ibm.com, sumanthk@...ux.ibm.com, 
	hca@...ux.ibm.com, japo@...ux.ibm.com
Subject: Re: [PATCH] perf test: Fix test case perf evlist tests for s390x

On Tue, Dec 9, 2025 at 2:50 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
>
> Perf test case 78: perf evlist tests fails on s390. The failure
> is causes by grouping events cycles and instructions because
> sampling does only support event cycles.
> Change the group to -e '{cycles,cycles}' to fix this.
>
> Output before:
>   # ./perf test 78
>   78: perf evlist tests              : FAILED!
>   #
>
> Output after:
>   # ./perf test 78
>   78: perf evlist tests              : Ok
>   #
>
> Fixes: db452961de939 ("perf tests evlist: Add basic evlist test")
> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>

Thanks Thomas, I always appreciate your help and fixes! Do you think
we should switch to software events to remedy this issue? Perhaps
cpu-clock and task-clock? I worry about event deduplication possibly
causing issues were it to happen.

Thanks,
Ian

> ---
>  tools/perf/tests/shell/evlist.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/evlist.sh b/tools/perf/tests/shell/evlist.sh
> index 140f099e75c1..80f808b3059d 100755
> --- a/tools/perf/tests/shell/evlist.sh
> +++ b/tools/perf/tests/shell/evlist.sh
> @@ -38,13 +38,13 @@ test_evlist_simple() {
>
>  test_evlist_group() {
>         echo "Group evlist test"
> -       if ! perf record -e "{cycles,instructions}" -o "${perfdata}" true 2> /dev/null
> +       if ! perf record -e "{cycles,cycles}" -o "${perfdata}" true 2> /dev/null
>         then
>                 echo "Group evlist [Skipped event group recording failed]"
>                 return
>         fi
>
> -       if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*instructions.*}"
> +       if ! perf evlist -i "${perfdata}" -g | grep -q "{.*cycles.*,.*cycles.*}"
>         then
>                 echo "Group evlist [Failed to list event group]"
>                 err=1
> --
> 2.52.0
>