linux-kernel - Re: [PATCH net 1/3] net: hns3: using the num_tqps in the vf driver to apply for resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aThVVMH-1bAzpX3K@horms.kernel.org>
Date: Tue, 9 Dec 2025 16:59:00 +0000
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, shenjian15@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com, lantao5@...wei.com,
	huangdonghua3@...artners.com, yangshuaisong@...artners.com,
	jonathan.cameron@...wei.com, salil.mehta@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/3] net: hns3: using the num_tqps in the vf driver
 to apply for resources

On Tue, Dec 09, 2025 at 09:38:23PM +0800, Jijie Shao wrote:
> From: Jian Shen <shenjian15@...wei.com>
> 
> Currently, hdev->htqp is allocated using hdev->num_tqps, and kinfo->tqp
> is allocated using kinfo->num_tqps. However, kinfo->num_tqps is set to
> min(new_tqps, hdev->num_tqps);  Therefore, kinfo->num_tqps may be smaller
> than hdev->num_tqps, which causes some hdev->htqp[i] to remain
> uninitialized in hclgevf_knic_setup().
> 
> Thus, this patch allocates hdev->htqp and kinfo->tqp using hdev->num_tqps,
> ensuring that the lengths of hdev->htqp and kinfo->tqp are consistent
> and that all elements are properly initialized.
> 
> Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support")
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>