linux-kernel - Re: [PATCH v4 2/3] iio: adc: ad9467: sort header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aThnybDs4lk9ht_f@smile.fi.intel.com>
Date: Tue, 9 Dec 2025 20:17:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomas Melin <tomas.melin@...sala.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Nuno Sa <nuno.sa@...log.com>, Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] iio: adc: ad9467: sort header includes

On Tue, Dec 09, 2025 at 05:46:16PM +0200, Tomas Melin wrote:
> On 09/12/2025 16:41, Andy Shevchenko wrote:
> > On Tue, Dec 9, 2025 at 7:34 AM Tomas Melin <tomas.melin@...sala.com> wrote:
> >>
> >> Include headers in ascending order.
> > 
> > Thanks, but...
> > 
> >>  #include <linux/iio/backend.h>
> >>  #include <linux/iio/iio.h>
> >>  #include <linux/iio/sysfs.h>
> > 
> > ...this was specifically grouped to show the relation to the certain
> > subsystem. At the end we should have something like this
> > 
> > linux/*.h // generic ones
> > ...blank line...
> > asm/*.h // generic ones (optionally, if there is a need in a such)
> > ...blank line...
> > linux/iio/*.h
> > ...blank line...
> 
> Thanks for the clarification. Sure, it's not a big deal to do a new
> version. But FWIW, that convention is not AFAIS explicitly stated
> anywhere and with even recent drivers not all following it, it's
> somewhat hard to know what expected formatting should be.
> It would really be good to have that documented somewhere.

I fully agree. The problem with such a documentation is that you will always
have 50/50% split at best. At worse ~100% will be against any doc updates
like this. For minimum we can do it on an IIO level (only for this subsystem),
see how others do Documentation/process/maintainer-*.rst. There is no IIO.
You can start it :-)

-- 
With Best Regards,
Andy Shevchenko