linux-kernel - Re: [PATCH] USB: serial: option: add Telit LE910 MBIM composition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRyCJF=gzm=wEq0wzYaHzZi=tuCOqkzxkpurX-ru2BvNeic6Q@mail.gmail.com>
Date: Tue, 9 Dec 2025 19:29:51 +0100
From: Daniele Palmas <dnlplm@...il.com>
To: Ulrich Mohr <u.mohr@...ex-engcon.com>
Cc: linux-usb@...r.kernel.org, Johan Hovold <johan@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: add Telit LE910 MBIM composition

Hello Ulrich,

Il giorno mar 9 dic 2025 alle ore 17:17 Ulrich Mohr
<u.mohr@...ex-engcon.com> ha scritto:
>
> Add support for Telit LE910 module when operating in MBIM composition
> with additional ttys. This usb product ID is used by the module
> when AT#USBCFG is set to 7.
>
> 0x1052: MBIM + tty(NMEA) + tty(MODM) + tty(MODEM) +SAP

This should be 0x1252.

> T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=1bc7 ProdID=1252 Rev=03.18
> S:  Manufacturer=Android
> S:  Product=LE910C1-EU
> S:  SerialNumber=0123456789ABCDEF
> C:  #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim
> E:  Ad=82(I) Atr=03(Int.) MxPS=  64 Ivl=32ms
> I:  If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=88(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=8a(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
>
> Signed-off-by: Ulrich Mohr <u.mohr@...ex-engcon.com>
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 5de856f65f0d..19921f129c0e 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -335,10 +335,11 @@ static void option_instat_callback(struct urb *urb);
>  #define TELIT_PRODUCT_LE920A4_1208             0x1208
>  #define TELIT_PRODUCT_LE920A4_1211             0x1211
>  #define TELIT_PRODUCT_LE920A4_1212             0x1212
>  #define TELIT_PRODUCT_LE920A4_1213             0x1213
>  #define TELIT_PRODUCT_LE920A4_1214             0x1214
> +#define TELIT_PRODUCT_LE910_USBCFG7            0x1252
>

The latest entries do not have a define, I think you can directly use the PID.

Regards,
Daniele

>  /* ZTE PRODUCTS */
>  #define ZTE_VENDOR_ID                          0x19d2
>  #define ZTE_PRODUCT_MF622                      0x0001
>  #define ZTE_PRODUCT_MF628                      0x0015
> @@ -1489,10 +1490,11 @@ static const struct usb_device_id option_ids[] = {
>         { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1230, 0xff),    /* Telit LE910Cx (rmnet) */
>           .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
>         { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff),    /* Telit LE910Cx (RNDIS) */
>           .driver_info = NCTRL(2) | RSVD(3) },
>         { USB_DEVICE_AND_INTERFACE_INFO(TELIT_VENDOR_ID, 0x1250, 0xff, 0x00, 0x00) },   /* Telit LE910Cx (rmnet) */
> +       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, TELIT_PRODUCT_LE910_USBCFG7, 0xff) },     /* Telit LE910Cx (MBIM) */
>         { USB_DEVICE(TELIT_VENDOR_ID, 0x1260),
>           .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
>         { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
>           .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
>         { USB_DEVICE(TELIT_VENDOR_ID, 0x1900),                          /* Telit LN940 (QMI) */
> --
> 2.39.5
>
>