linux-kernel - Re: [PATCH v5] tty: tty_port: add workqueue to flip tty buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251210020817.3703454-1-jackzxcui1989@163.com>
Date: Wed, 10 Dec 2025 10:08:17 +0800
From: Xin Zhao <jackzxcui1989@....com>
To: jirislaby@...nel.org
Cc: gregkh@...uxfoundation.org,
	hch@...radead.org,
	jackzxcui1989@....com,
	linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	tj@...nel.org
Subject: Re: [PATCH v5] tty: tty_port: add workqueue to flip tty buffer

Dear Jiri,

On Mon, 8 Dec 2025 08:26:51 +0100 Jiri Slaby <jirislaby@...nel.org> wrote:

> > +	if (!(driver->flags & TTY_DRIVER_CUSTOM_WORKQUEUE)) {
> > +		driver->flip_wq = alloc_workqueue("%s-flip-wq",
> > +						WQ_UNBOUND | WQ_SYSFS,
> > +						0, driver->name);
> 
> Do you have to wrap the line here?

It looks like I need to add line breaks:

./scripts/checkpatch.pl 0001-tty-tty_port-add-workqueue-to-flip-tty-buffer.patch

WARNING: line length of 104 exceeds 100 columns
#227: FILE: drivers/tty/tty_io.c:3450:
+               driver->flip_wq = alloc_workqueue("%s-flip-wq", WQ_UNBOUND | WQ_SYSFS, 0, driver->name);

--
Xin Zhao