linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3393067.44csPzL39Z@debian-vmware>
Date: Wed, 10 Dec 2025 10:41:27 +0800
From: Jingzhou Zhu <newwheatzjz@...omail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct
 ipa_fw_mem for the driver to load successfully

On Wednesday, 10 December 2025 07:08:41 CST, Dmitry Baryshkov wrote:
> On Mon, Dec 08, 2025 at 11:15:11AM +0800, Jingzhou Zhu wrote:
> > The ipa driver refuses to load with the old ipa_fw_mem in newer kernels.
> > Shrinking its size to 0x5a000 fixes the problem.
> > 
> > Fixes: aab69794b55d ("arm64: dts: qcom: Add support for Huawei MateBook E 2019")
> > 
> > Signed-off-by: Jingzhou Zhu <newwheatzjz@...omail.com>
> 
> There should be no empty lines between tags.
> 

Understood.

> > ---
> >  arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > index a5f025ae7dbe..f04865381870 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > @@ -144,12 +144,12 @@ wlan_msa_mem: wlan-msa@...00000 {
> >  		};
> >  
> >  		ipa_fw_mem: ipa-fw@...00000 {
> > -			reg = <0 0x8df00000 0 0x100000>;
> > +			reg = <0 0x8df00000 0 0x5a000>;
> >  			no-map;
> >  		};
> >  
> > -		gpu_mem: gpu@...00000 {
> > -			reg = <0 0x97900000 0 0x5000>;
> > +		gpu_mem: gpu@...5a000 {
> 
> Why are you adjusting gpu_mem?
> 

In sdm845.dtsi, ipa_fw_mem is followed by gpu_mem, so I moved gpu_mem to
0x8df5a000 since the memory was freed after shrinking ipa_fw_mem size.
I'm not sure whether the order matters, but I think it's best to follow
how they are arranged in sdm845.dtsi.

Also, this change didn't seem to cause problems according to my testing.

> > +			reg = <0 0x8df5a000 0 0x5000>;
> >  			no-map;
> >  		};
> >  
> 
>