linux-kernel - Re: [PATCH 11/13] smb: introduce struct create_posix_ctxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531e1da0-b353-4285-855f-a7f023ab6dde@linux.dev>
Date: Wed, 10 Dec 2025 08:37:39 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org,
 linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
 liuzhengyuan@...inos.cn, huhai@...inos.cn, liuyun01@...inos.cn,
 ZhangGuoDong <zhangguodong@...inos.cn>
Subject: Re: [PATCH 11/13] smb: introduce struct create_posix_ctxt_rsp

Hi Namjae,

In the POSIX-SMB2 2.2.14.2.16 documentation, the OwnerSID and GroupSID 
fields in this structure are flexible members, and how these two SIDs 
are defined depends on where the structure is used.

https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/smb3_posix_extensions.md#2214216-smb2_create_posix_context-response

Thanks,
ChenXiaoSong.

On 12/10/25 8:31 AM, Namjae Jeon wrote:
> On Wed, Dec 10, 2025 at 9:13 AM ChenXiaoSong
> <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>> Hi Namjae,
>>
>> The `create_posix_rsp` structures on the client and server sides differ,
>> but they share a common part, and only this common part is defined in
>> POSIX‑SMB2 2.2.14.2.16.
> I agree with moving create_posix_rsp struct to common, but doing it
> partially feels forced and unnatural.