linux-kernel - Re: [PATCH 00/14] tools/virtio: cleanups, fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEuFZHgD8Shq6w_QfKYh0p3w8pfhY2mw_+ieQv0U14d8NA@mail.gmail.com>
Date: Wed, 10 Dec 2025 14:24:02 +0800
From: Jason Wang <jasowang@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 00/14] tools/virtio: cleanups, fixes

On Tue, Dec 9, 2025 at 9:09 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Thu, Dec 04, 2025 at 01:46:01PM -0500, Michael S. Tsirkin wrote:
> > Recent virtio changes brought about build errors for tools/virtio,
> > as usual. I did some refactoring to hopefully reduce maintainance
> > load going forward.
> >
> > Adding stubs is tedious and seemed a perfect fit for cursor -
> > so I used it for that, then rewrote some commits and accepted
> > others.  commit logs I've rewritten.
> >
> > Found and fixed a couple of minor bugs while doing this - that
> > part's all mine.
>
>
> Jason, any feedback?

Looks good to me. But I wonder, it looks like synchronization will
become more and more a burden in the future, I wonder if it's time to
switch to using uAPI instead of trying to reuse kernel virtio core to
test vhost?

Thanks

>
> > Michael S. Tsirkin (14):
> >   tools/virtio: fix up compiler.h stub
> >   virtio: make it self-contained
> >   tools/virtio: use kernel's virtio.h
> >   tools/virtio: add struct module forward declaration
> >   tools/virtio: stub DMA mapping functions
> >   tools/virtio: add dev_WARN_ONCE and is_vmalloc_addr stubs
> >   tools/virtio: add ucopysize.h stub
> >   tools/virtio: pass KCFLAGS to module build
> >   tools/virtio: add struct cpumask to cpumask.h
> >   tools/virtio: stub might_sleep and synchronize_rcu
> >   tools/virtio: switch to kernel's virtio_config.h
> >   virtio_features: make it self-contained
> >   tools/virtio: fix up oot build
> >   tools/virtio: add device, device_driver stubs
> >
> >  include/linux/virtio.h             |   2 +
> >  include/linux/virtio_features.h    |   2 +
> >  tools/virtio/Makefile              |   8 ++-
> >  tools/virtio/linux/compiler.h      |   6 ++
> >  tools/virtio/linux/cpumask.h       |   4 ++
> >  tools/virtio/linux/device.h        |   8 +++
> >  tools/virtio/linux/dma-mapping.h   |   4 ++
> >  tools/virtio/linux/kernel.h        |  16 +++++
> >  tools/virtio/linux/module.h        |   2 +
> >  tools/virtio/linux/ucopysize.h     |  21 ++++++
> >  tools/virtio/linux/virtio.h        |  73 +--------------------
> >  tools/virtio/linux/virtio_config.h | 102 +----------------------------
> >  tools/virtio/oot-stubs.h           |  10 +++
> >  13 files changed, 82 insertions(+), 176 deletions(-)
> >  create mode 100644 tools/virtio/linux/ucopysize.h
> >  create mode 100644 tools/virtio/oot-stubs.h
> >
> > --
> > MST
> >
>