linux-kernel - Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025121023-cabdriver-pyromania-80c6@gregkh>
Date: Wed, 10 Dec 2025 16:37:03 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Aaron Tomlin <atomlin@...mlin.com>
Cc: Lance Yang <lance.yang@...ux.dev>, sean@...e.io,
	linux-kernel@...r.kernel.org, mhiramat@...nel.org,
	akpm@...ux-foundation.org, Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an
 atomic log block

On Tue, Dec 09, 2025 at 05:14:40PM -0500, Aaron Tomlin wrote:
> On Tue, Dec 09, 2025 at 03:56:58PM +0900, Greg KH wrote:
> > > "%s\n" forces an unconditional newline, causing a spurious blank line when
> > > the flag isn't set, right?
> > 
> > The first \n should not be there, this should be all one line.
> 
> Hi Greg,
> 
> I agree. This will be resolved in a subsequent patch.
> 
> > If you have multiple lines wanting to be printed, use multiple pr_err()
> > calls.
> 
> Unfortunately, sequential pr_err() calls risk having their lines separated
> by other log messages, rendering the warning incoherent. The single-call
> implementation is necessary to ensure the entire message is atomically
> written.

Then perhaps you all shouldn't be dumping all that amount of information
if that's the only api you all are attempting to rely on here?

What is the goal, this should just be debugging information, no tool
should be requiring this, right?

thanks,

greg k-h