[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <797f93b5-e31c-4ee8-96fd-4d974daa0b3c@oss.qualcomm.com>
Date: Tue, 9 Dec 2025 16:41:33 -0800
From: Deepa Guthyappa Madivalara <deepa.madivalara@....qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Vikash Garodia <vikash.garodia@....qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
Abhinav Kumar <abhinav.kumar@...ux.dev>,
Bryan O'Donoghue <bod@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7 4/5] media: iris: Define AV1-specific platform
capabilities and properties
On 12/6/2025 3:36 PM, Bryan O'Donoghue wrote:
> On 10/11/2025 17:21, Deepa Guthyappa Madivalara wrote:
>> #define HFI_PROP_BUFFER_MARK 0x0300016c
>> +#define HFI_PROP_WORST_COMPRESSION_RATIO 0x03000174
>> +#define HFI_PROP_WORST_COMPLEXITY_FACTOR 0x03000175
>> #define HFI_PROP_RAW_RESOLUTION 0x03000178
>> #define HFI_PROP_TOTAL_PEAK_BITRATE 0x0300017C
>> -#define HFI_PROP_OPB_ENABLE 0x03000184
>> +#define HFI_PROP_AV1_FILM_GRAIN_PRESENT 0x03000180
>> +#define HFI_PROP_AV1_SUPER_BLOCK_ENABLED 0x03000181
>> +#define HFI_PROP_AV1_OP_POINT 0x03000182
>> +#define HFI_PROP_OPB_ENABLE 0x03000184
>> +#define HFI_PROP_AV1_TILE_ROWS_COLUMNS 0x03000187
>> +#define HFI_PROP_AV1_DRAP_CONFIG 0x03000189
>> #define HFI_PROP_COMV_BUFFER_COUNT 0x03000193
>> +#define HFI_PROP_AV1_UNIFORM_TILE_SPACING 0x03000197
>
> I'll fix this for you because I'm infinitely sound BUT
>
> #define HFI_PROP_AV1_FILM_GRAIN_PRESENT 0x03000180
> #define HFI_PROP_AV1_SUPER_BLOCK_ENABLED 0x03000181
> #define HFI_PROP_AV1_OP_POINT 0x03000182
> #define HFI_PROP_OPB_ENABLE 0x03000184
> #define HFI_PROP_AV1_TILE_ROWS_COLUMNS 0x03000187
> #define HFI_PROP_AV1_DRAP_CONFIG 0x03000189
>
> please stop using whitespace for tabs !
>
> ---
> bod
Sorry, updated to tabs in v9.
>
Powered by blists - more mailing lists