linux-kernel - Re: [PATCH] cpufreq: dt-platdev: Fix creating device on OPPv1 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <202512101003.34566.pisa@fel.cvut.cz>
Date: Wed, 10 Dec 2025 10:03:34 +0100
From: Pavel Pisa <pisa@....cvut.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
 Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 "Rob Herring (Arm)" <robh@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] cpufreq: dt-platdev: Fix creating device on OPPv1 platforms

Thanks much for the fast response and fix. I have run checks
successfully without revert 6ea891a6dd37 and this patch applied.

On Wednesday 10 of December 2025 06:17:19 Krzysztof Kozlowski wrote:
> Commit 6ea891a6dd37 ("cpufreq: dt-platdev: Simplify with
> of_machine_get_match_data()") broke several platforms which did not have
> OPPv2 proprety, because it incorrectly checked for device match data
> after first matching from "allowlist".  Almost all of "allowlist" match
> entries do not have match data and it is expected to create platform
> device for them with empty data.
>
> Fix this by first checking if platform is on the allowlist with
> of_machine_device_match() and only then taking the match data.  This
> duplicates the number of checks (we match against the allowlist twice),
> but makes the code here much smaller.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Closes:
> https://lore.kernel.org/all/CAMuHMdVJD4+J9QpUUs-sX0feKfuPD72CO0dcqN7shvF_UY
>pZ3Q@...l.gmail.com/ Reported-by: Pavel Pisa <pisa@....cvut.cz>
> Closes:
> https://lore.kernel.org/all/6hnk7llbwdezh74h74fhvofbx4t4jihel5kvr6qwx2xuxxb
>jys@...bd7lkhrdz/ Fixes: 6ea891a6dd37 ("cpufreq: dt-platdev: Simplify with
> of_machine_get_match_data()") Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@....qualcomm.com> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Tested-by: Pavel Pisa <pisa@....cvut.cz>
on AMD Xilinx Zynq MicroZed xlnx,zynq-7000 platform.

As for the initial report, I have located addresses for CPUfreq
maintainers from the mainline MAINTAINERS file - Rafael J. Wysocki
and Viresh Kumar and PM list, I have added Michal Simek as AMD Xilinx
platform maintainer. I have done quick glimpse into history and have
seen some recent patches but have not time to do bisect so 
I decided start with some maintainers the first to not spam too much
people. Then repeated to the already extended addresses list.

Best wishes,

                Pavel

                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@....felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    social:     https://social.kernel.org/ppisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home