linux-kernel - Re: [PATCH v3] net/handshake: restore destructor on submit failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176535841527.523551.15411391386973921361.git-patchwork-notify@kernel.org>
Date: Wed, 10 Dec 2025 09:20:15 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: caoping <caoping@...s.chinamobile.com>
Cc: chuck.lever@...cle.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 kernel-tls-handshake@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] net/handshake: restore destructor on submit failure

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu,  4 Dec 2025 01:10:58 -0800 you wrote:
> handshake_req_submit() replaces sk->sk_destruct but never restores it when
> submission fails before the request is hashed. handshake_sk_destruct() then
> returns early and the original destructor never runs, leaking the socket.
> Restore sk_destruct on the error path.
> 
> Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handling handshake requests")
> Reviewed-by: Chuck Lever <chuck.lever@...cle.com>
> Cc: stable@...r.kernel.org
> Signed-off-by: caoping <caoping@...s.chinamobile.com>
> 
> [...]

Here is the summary with links:
  - [v3] net/handshake: restore destructor on submit failure
    https://git.kernel.org/netdev/net/c/6af2a01d65f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html