| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <df33c967-8dc1-4353-9b3a-e507c7ddd072@ti.com> Date: Wed, 10 Dec 2025 15:03:59 +0530 From: Yemike Abhilash Chandra <y-abhilashchandra@...com> To: Rob Herring <robh@...nel.org> CC: <tomi.valkeinen@...asonboard.com>, <mchehab@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <hverkuil@...all.nl>, <sakari.ailus@...ux.intel.com>, <laurent.pinchart@...asonboard.com>, <hansg@...nel.org>, <mehdi.djait@...ux.intel.com>, <ribalda@...omium.org>, <git@...tzsch.eu>, <vladimir.zapolskiy@...aro.org>, <benjamin.mugnier@...s.st.com>, <dongcheng.yan@...el.com>, <u-kumar1@...com>, <jai.luthra@...ux.dev>, <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH V2 3/4] media: dt-bindings: ti,ds90ub960: Add support for DS90UB954-Q1 On 05/12/25 20:47, Rob Herring wrote: > On Tue, Dec 02, 2025 at 03:52:07PM +0530, Yemike Abhilash Chandra wrote: >> DS90UB954-Q1 is an FPDLink-III deserializer that is mostly register >> compatible with DS90UB960-Q1. The main difference is that it supports >> half of the RX and TX ports, i.e. 2x FPDLink RX ports and 1x CSI TX >> port. Therefore, add support for DS90UB954 within the existing bindings. >> >> Link: https://www.ti.com/lit/gpn/ds90ub954-q1 >> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com> >> --- >> .../bindings/media/i2c/ti,ds90ub960.yaml | 300 +++++++++++++++--- >> 1 file changed, 264 insertions(+), 36 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml >> index 6a78288aebaa..1ef977c2e479 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml >> @@ -13,12 +13,10 @@ description: >> The TI DS90UB9XX devices are FPD-Link video deserializers with I2C and GPIO >> forwarding. >> >> -allOf: >> - - $ref: /schemas/i2c/i2c-atr.yaml# >> - >> properties: >> compatible: >> enum: >> + - ti,ds90ub954-q1 >> - ti,ds90ub960-q1 >> - ti,ds90ub9702-q1 >> >> @@ -129,39 +127,6 @@ properties: >> Ports represent FPD-Link inputs to the deserializer and CSI TX outputs from the deserializer. >> Their number is model-dependent. >> >> - properties: >> - port@0: >> - $ref: '#/$defs/FPDLink-input-port' >> - description: FPD-Link input 0 >> - >> - port@1: >> - $ref: '#/$defs/FPDLink-input-port' >> - description: FPD-Link input 1 >> - >> - port@2: >> - $ref: '#/$defs/FPDLink-input-port' >> - description: FPD-Link input 2 >> - >> - port@3: >> - $ref: '#/$defs/FPDLink-input-port' >> - description: FPD-Link input 3 >> - >> - port@4: >> - $ref: '#/$defs/CSI2-output-port' >> - description: CSI-2 Output 0 >> - >> - port@5: >> - $ref: '#/$defs/CSI2-output-port' >> - description: CSI-2 Output 1 >> - >> - required: >> - - port@0 >> - - port@1 >> - - port@2 >> - - port@3 >> - - port@4 >> - - port@5 >> - >> required: >> - compatible >> - reg >> @@ -204,9 +169,86 @@ $defs: >> - data-lanes >> - link-frequencies >> >> +allOf: >> + - $ref: /schemas/i2c/i2c-atr.yaml# >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - ti,ds90ub960-q1 >> + - ti,ds90ub9702-q1 >> + then: >> + properties: >> + ports: >> + properties: >> + port@0: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 0 >> + >> + port@1: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 1 >> + >> + port@2: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 2 >> + >> + port@3: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 3 >> + >> + port@4: >> + $ref: '#/$defs/CSI2-output-port' >> + description: CSI-2 Output 0 >> + >> + port@5: >> + $ref: '#/$defs/CSI2-output-port' >> + description: CSI-2 Output 1 >> + >> + required: >> + - port@0 >> + - port@1 >> + - port@2 >> + - port@3 >> + - port@4 >> + - port@5 >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: ti,ds90ub954-q1 >> + then: >> + properties: >> + ports: >> + properties: >> + port@0: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 0 >> + >> + port@1: >> + $ref: '#/$defs/FPDLink-input-port' >> + description: FPD-Link input 1 >> + >> + port@2: >> + $ref: '#/$defs/CSI2-output-port' >> + description: CSI-2 Output 0 > > Wouldn't making this port@4 be more compatible? > The current driver expects the TX port numbers to start immediately after the RX ports. If I change this to port@4, I would also need to update the driver. Can I keep the port numbering as it is? >> + >> + required: >> + - port@0 >> + - port@1 >> + - port@2 >> + >> + links: >> + properties: >> + link@2: false >> + link@3: false >> + >> unevaluatedProperties: false >> >> examples: >> + # Example with ds90ub960 Deserializer >> - | >> #include <dt-bindings/gpio/gpio.h> >> >> @@ -406,4 +448,190 @@ examples: >> }; >> }; >> }; >> + >> + # Example with ds90ub954 Deserializer >> + - | >> + #include <dt-bindings/gpio/gpio.h> > > I don't think we really need a whole other example for something > that's a subset. > Make sense. I will remove the example in v3. Thanks and Regards, Yemike Abhilash Chandra > Rob >
Powered by blists - more mailing lists