linux-kernel - Re: [PATCH 8/9] bitfield: Add comment block for the host/fixed endian functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251210100846.04e59dcf@pumpkin>
Date: Wed, 10 Dec 2025 10:08:46 +0000
From: David Laight <david.laight.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Yury Norov <yury.norov@...il.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-kernel@...r.kernel.org,
 linux-usb@...r.kernel.org, Geert Uytterhoeven <geert+renesas@...der.be>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Crt Mori <cmo@...exis.com>, Richard Genoud
 <richard.genoud@...tlin.com>, Andy Shevchenko
 <andriy.shevchenko@...el.com>, Luo Jie <quic_luoj@...cinc.com>, Peter
 Zijlstra <peterz@...radead.org>, netdev@...r.kernel.org, "David S . Miller"
 <davem@...emloft.net>, Simon Horman <simon.horman@...ronome.com>, Mika
 Westerberg <mika.westerberg@...ux.intel.com>, Andreas Noever
 <andreas.noever@...il.com>, Yehezkel Bernat <YehezkelShB@...il.com>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Subject: Re: [PATCH 8/9] bitfield: Add comment block for the host/fixed
 endian functions

On Wed, 10 Dec 2025 18:23:00 +0900
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue,  9 Dec 2025 10:03:12 +0000 david.laight.linux@...il.com wrote:
> > + * * u32 le32_get_bits(__le32 val, u32 field) extracts the contents of the
> > + *   bitfield specified by @field in little-endian 32bit object @val and
> > + *   converts it to host-endian.  
> 
> possibly also add declarations for these? So that ctags and co. sees
> them?

The functions are bulk-generated using a #define, ctags is never going to
find definitions.

Adding kerneldoc comments is also painful.
I don't think it lets you use a single comment for multiple functions.

	David