linux-kernel - Re: [PATCH v2 2/3] of: factor arguments passed to of_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <788d981e-7186-479c-8961-8b16482aa5bf@oss.qualcomm.com>
Date: Wed, 10 Dec 2025 15:59:07 +0530
From: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
To: Rob Herring <robh@...nel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, robin.murphy@....com,
        will@...nel.org, joro@...tes.org, konrad.dybcio@....qualcomm.com,
        bjorn.andersson@....qualcomm.com, bod@...nel.org, conor+dt@...nel.org,
        krzk+dt@...nel.org, charan.kalla@....qualcomm.com,
        prakash.gupta@....qualcomm.com, vikash.garodia@....qualcomm.com,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a
 struct



On 12/10/2025 1:32 AM, Rob Herring wrote:
> On Mon, Dec 08, 2025 at 07:10:32PM +0530, Vijayanand Jitta wrote:
>>
>>
>> On 12/5/2025 10:17 PM, Dmitry Baryshkov wrote:
>>> On 04/12/2025 11:55, Vijayanand Jitta wrote:
>>>> From: Charan Teja Kalla <charan.kalla@....qualcomm.com>
>>>>
>>>> Introduce a new struct type where the optional arguments passed to
>>>> of_map_id() are in struct. Subsequent patches add additional arguments
>>>> to the struct that the caller expects to be filled of_map_id().
>>>
>>> Why do we need a separate struct? Can't we use of_phandle_args instead?
>>>
>>
>> The idea is to use it for multi-map support mentioned in the cover letter,
>> where we need to pass additional context (callback, dev etc..). Having a
>> seperate structure here makes of_map_id() interface easier to extend.
> 
> Then perhaps?:
> 
> struct of_map_id_args {
> 	struct of_phandle_args args;
>         ...
> }
> 

Thanks, this will work. Will update it in next revision.
>>
>>>>
>>>> Signed-off-by: Charan Teja Kalla <charan.kalla@....qualcomm.com>
>>>> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@....qualcomm.com>
>>>> ---
>>>>   drivers/iommu/of_iommu.c              |  6 +++++-
>>>>   drivers/of/base.c                     | 31 ++++++++++++++-------------
>>>>   drivers/pci/controller/dwc/pci-imx6.c |  6 +++++-
>>>>   drivers/pci/controller/pcie-apple.c   |  5 ++++-
>>>>   drivers/xen/grant-dma-ops.c           |  5 ++++-
>>>>   include/linux/of.h                    | 23 ++++++++++++++------
>>>>   6 files changed, 50 insertions(+), 26 deletions(-)
>>>>
>>