linux-kernel - Re: [PATCH v6 6/8] arm64: dts: qcom: ipq5332: add nodes to bring up q6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB888320190F3C44CE78D937B29DA0A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Wed, 10 Dec 2025 14:33:12 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Manikanta Mylavarapu <quic_mmanikan@...cinc.com>,
 Jassi Brar <jassisinghbrar@...il.com>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 devicetree@...r.kernel.org,
 Gokul Sriram Palanisamy <gokul.sriram.p@....qualcomm.com>
Subject: Re: [PATCH v6 6/8] arm64: dts: qcom: ipq5332: add nodes to bring up
 q6



On 12/10/25 00:06, Dmitry Baryshkov wrote:
> On Mon, Dec 08, 2025 at 04:25:38PM +0400, George Moussalem via B4 Relay wrote:
>> From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>>
>> Enable nodes required for q6 remoteproc bring up.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> Signed-off-by: Gokul Sriram Palanisamy <gokul.sriram.p@....qualcomm.com>
>> Signed-off-by: George Moussalem <george.moussalem@...look.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 64 ++++++++++++++++++++++++++++++++++-
>>  1 file changed, 63 insertions(+), 1 deletion(-)
>> @@ -871,4 +909,28 @@ timer {
>>  			     <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>>  			     <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>>  	};
>> +
>> +	wcss: smp2p-wcss {
> 
> Please keep the nodes sorted by name: this node should come before
> soc@0 (here and in other DTSI too).

Thanks, will update and sort by node name.

> 
>> +		compatible = "qcom,smp2p";
>> +		qcom,smem = <435>, <428>;
>> +
>> +		interrupt-parent = <&intc>;
>> +		interrupts = <GIC_SPI 418 IRQ_TYPE_EDGE_RISING>;
>> +
>> +		mboxes = <&apcs_glb 9>;
>> +
>> +		qcom,local-pid = <0>;
>> +		qcom,remote-pid = <1>;
>> +
>> +		smp2p_wcss_out: master-kernel {
>> +			qcom,entry-name = "master-kernel";
>> +			#qcom,smem-state-cells = <1>;
>> +		};
>> +
>> +		smp2p_wcss_in: slave-kernel {
>> +			qcom,entry-name = "slave-kernel";
>> +			interrupt-controller;
>> +			#interrupt-cells = <2>;
>> +		};
>> +	};
>>  };
>>
>> -- 
>> 2.52.0
>>
>>
> 

Best regards,
George