[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANXQDtYMSGzhOa+Ja=r2ytAh63DYWvebXR12272YXUkZX355qg@mail.gmail.com>
Date: Wed, 10 Dec 2025 16:13:53 +0530
From: Bhargava Chenna Marreddy <bhargava.marreddy@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
andrew+netdev@...n.ch, horms@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, michael.chan@...adcom.com,
pavan.chebbi@...adcom.com, vsrama-krishna.nemani@...adcom.com,
vikas.gupta@...adcom.com
Subject: Re: [v3, net-next 00/12] bng_en: enhancements for link, Rx/Tx,
LRO/TPA & stats
On Sat, Nov 29, 2025 at 12:14 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 28 Nov 2025 20:29:47 +0530 Bhargava Chenna Marreddy wrote:
> > > On Thu, 27 Nov 2025 01:19:19 +0530 Bhargava Marreddy wrote:
> > > > This series enhances the bng_en driver by adding:
> > > > 1. Link query support
> > > > 2. Tx support (standard + TSO)
> > > > 3. Rx support (standard + LRO/TPA)
> > > > 4. ethtool link set/get functionality
> > > > 5. Hardware statistics reporting via ethtool S
> > >
> > > > 13 files changed, 5729 insertions(+), 50 deletions(-)
> > >
> > > This should be 2 or 3 series, really.
> >
> > We would appreciate it if you could allow this current patch series to
> > be accepted for review. We commit to ensuring all future patch series
> > submissions will be smaller and more manageable.
> > If this is not acceptable, please let us know, and we will rework the
> > current series.
>
> current as in v3? Or you'll make v4 similarly humongous?
> Look, we're not trying to be difficult. If you keep posting 6kLoC
> at a time it will sit in a queue for 3 days each time and probably
> reach v20. It is just quicker to get code upstream with smaller
> submissions.
>
> There are some very seasoned upstream contributors within Broadcom,
> please talk to them?
We agree that a larger series can require a lot of effort from reviewers.
We will keep v4 limited to TX and RX only — roughly ~2.5 K LOC.
Hopefully this size will be good to proceed further.
Thanks,
Bhargava Marreddy
Download attachment "smime.p7s" of type "application/pkcs7-signature" (5496 bytes)
Powered by blists - more mailing lists