linux-kernel - Re: [PATCH v1 1/1] leds: Unexport of_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTlon6M4Gn0AuXyz@smile.fi.intel.com>
Date: Wed, 10 Dec 2025 14:33:35 +0200
From: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
To: Jonathan Brophy <J.Brophy@...killsystems.co.nz>
Cc: "lee@...nel.org" <lee@...nel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	Pavel Machek <pavel@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] leds: Unexport of_led_get()

On Wed, Dec 10, 2025 at 10:43:38AM +0000, Jonathan Brophy wrote:
>  [PATCH v1 1/1] leds: Unexport of_led_get()
> 
> it would seem the removal of this function has removed the only way to search
> led phandles the device tree.

Are you talking about upstream drivers that now regressed somehow or is it
about downstream?

> The devm version works functionally different and is not a replacement.
> virtual led grouping drivers are unable to match phandles.
> is there plans to create a fwnode_led_get() replacment for of_led_get ?

When there will be a user that may not call existing APIs.

> The problem is gpio leds don't have fwnode properties so searching by
> platform does not work.

Can you elaborate? I think your downstream code (I have no other ideas
where you Q came from) uses some outdated approaches. Try to look at
the problem from the level of the existing APIs and frameworks. We shouldn't
really have such an issue (but it might be some special use case, I admit).


-- 
With Best Regards,
Andy Shevchenko