linux-kernel - Re: [PATCH v1] LoongArch: Remove unnecessary checks in bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92bf0e88-da14-20ce-137a-3e7777e19af3@loongson.cn>
Date: Wed, 10 Dec 2025 09:28:53 +0800
From: Tiezhu Yang <yangtiezhu@...ngson.cn>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] LoongArch: Remove unnecessary checks in bt_address()

On 2025/12/9 下午4:30, Huacai Chen wrote:
> Hi, Tiezhu,
> 
> On Tue, Dec 9, 2025 at 2:18 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>>
...
>>          extern unsigned long eentry;
>>
>> -       if (__kernel_text_address(ra))
>> -               return ra;
>> -
>> -       if (__module_text_address(ra))
>> -               return ra;
> I think the correct way is to remove the __module_text_address()
> condition but keep the __kernel_text_address() condition. Then return
> 0 at the end of this function, and remove the __kernel_text_address()
> condition out of this function.

It can not remove the check of __kernel_text_address() after calling
bt_address() because it needs to validate the calculated address for
exception, then no need to keep the __kernel_text_address() condition
in bt_address() because it will check the PC outside bt_address().

Thanks,
Tiezhu