linux-kernel - Re: [PATCH] drm/i915: Fix BO alloc flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad82a9af-eb79-47ef-a5d3-662cff3c0ee2@ursulin.net>
Date: Wed, 10 Dec 2025 15:08:02 +0100
From: Tvrtko Ursulin <tursulin@...ulin.net>
To: Loïc Molinari <loic.molinari@...labora.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Mikołaj Wasiak <mikolaj.wasiak@...el.com>,
 Andi Shyti <andi.shyti@...ux.intel.com>,
 Christopher Healy <healych@...zon.com>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, kernel@...labora.com,
 Chaitanya Kumar Borah <chaitanya.kumar.borah@...el.com>
Subject: Re: [PATCH] drm/i915: Fix BO alloc flags


On 10/12/2025 12:09, Loïc Molinari wrote:
> I915_BO_ALLOC_NOTHP must be added to the I915_BO_ALLOC_FLAGS mask in
> order to pass GEM_BUG_ON() valid flags checks.
>
> Reported-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@...el.com>
> Closes: https://lore.kernel.org/intel-gfx/d73adfa8-d61b-46b3-9385-dde53d8db8ad@intel.com/
> Fixes: a8a9a590221c ("drm/i915: Use huge tmpfs mountpoint helpers")
> Suggested-by: Tvrtko Ursulin <tursulin@...ulin.net>
> Signed-off-by: Loïc Molinari <loic.molinari@...labora.com>
> ---
>   drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> index f94409e8ec4c..35d4c7d0c579 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> @@ -363,6 +363,7 @@ struct drm_i915_gem_object {
>   			     I915_BO_ALLOC_PM_EARLY | \
>   			     I915_BO_ALLOC_GPU_ONLY | \
>   			     I915_BO_ALLOC_CCS_AUX | \
> +			     I915_BO_ALLOC_NOTHP | \
>   			     I915_BO_PREALLOC)
>   #define I915_BO_READONLY          BIT(10)
>   #define I915_TILING_QUIRK_BIT     11 /* unknown swizzling; do not release! */

Acked-by: Tvrtko Ursulin <tvrtko.ursulin@...lia.com>

It is passing BAT so I think it is fine to go ahead and merge it. Of 
course via the same branch where the breakage is ie. drm-misc.

Regards,

Tvrtko