linux-kernel - Re: [PATCH] pinctrl: fix compile test defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251210-judiciary-borough-1c28d14b9a3f@spud>
Date: Wed, 10 Dec 2025 14:22:02 +0000
From: Conor Dooley <conor@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Linus Walleij <linusw@...nel.org>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH] pinctrl: fix compile test defaults

On Wed, Dec 10, 2025 at 12:41:48PM +0900, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that) but two new drivers got this wrong.
> 
> Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> Cc: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index bc7f37afc48b..ce5685215b92 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP

Nah, not a fan of this kind of thing, please just make it default n if
this compile test behaviour bothers you.

>  	help
>  	  This selects the pinctrl driver for gpio2 on pic64gx.
>  
> @@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
>  	select GENERIC_PINCONF
> -	default y
> +	default ARCH_MICROCHIP
>  	help
>  	  This selects the pinctrl driver for Microchip Polarfire SoC.
>  
> -- 
> 2.52.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)