linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mmc: renesas,sdhi: Add mux-states property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8db3548a-5e01-47fd-99ef-dcd694abc786@solid-run.com>
Date: Wed, 10 Dec 2025 14:49:46 +0000
From: Josua Mayer <josua@...id-run.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Geert Uytterhoeven
	<geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, Mikhail Anikin
	<mikhail.anikin@...id-run.com>, Yazan Shhady <yazan.shhady@...id-run.com>,
	Jon Nettleton <jon@...id-run.com>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: renesas,sdhi: Add mux-states
 property

Am 09.12.25 um 13:08 schrieb Ulf Hansson:

> On Mon, 1 Dec 2025 at 13:31, Josua Mayer <josua@...id-run.com> wrote:
>> Add mux controller support for when sdio lines are muxed between a host
>> and multiple cards.
> We have the SD, SDIO, (e)MMC interfaces with their corresponding pins.
> Using "sdio lines" becomes confusing as it kind of indicates this is
> for "SDIO" only.
Agreed.
>
>> There are several devices supporting a choice of eMMC or SD on a single
>> board by both dip switch and gpio, e.g. Renesas RZ/G2L SMARC SoM and
>> SolidRun RZ/G2L SoM.
>>
>> In-tree dts for the Renesas boards currently rely on preprocessor macros
>> to hog gpios and define the card.
>>
>> By adding mux-states property to sdio controller description, boards can
> Again, please don't use "sdio" here.
Ack.
>
>> correctly describe the mux that already exists in hardware - and drivers
>> can coordinate between mux selection and probing for cards.
>>
>> Signed-off-by: Josua Mayer <josua@...id-run.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>> index c754ea71f51f7..754ccb1c30efb 100644
>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>> @@ -106,6 +106,11 @@ properties:
>>    iommus:
>>      maxItems: 1
>>
>> +  mux-states:
>> +    description:
>> +      mux controller node to route the SDIO signals from SoC to cards.
> I suggest we change from "SDIO" to "SD/SDIO/eMMC".

Agreed.

I will replace here, and reword each commit description for v3.

>
>> +    maxItems: 1
>> +
>>    power-domains:
>>      maxItems: 1
>>
>> @@ -275,6 +280,7 @@ examples:
>>          max-frequency = <195000000>;
>>          power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
>>          resets = <&cpg 314>;
>> +        mux-states = <&mux 0>;
>>      };
>>
>>      sdhi1: mmc@...20000 {
>>
>> --
>> 2.51.0
>>
>>
> Kind regards
> Uffe
>
>