linux-kernel - Re: [PATCH] HFS: btree: fix missing error check after hfs_bnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67b5e999-2380-46db-aee1-a81df3ceeb36@web.de>
Date: Wed, 10 Dec 2025 18:09:24 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, linux-fsdevel@...r.kernel.org,
 John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 Viacheslav Dubeyko <slava@...eyko.com>, Yangtao Li <frank.li@...o.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HFS: btree: fix missing error check after
 hfs_bnode_find()

> In hfs_brec_insert() and hfs_brec_update_parent(), hfs_bnode_find()
> may return ERR_PTR() on failure, but the result was used without
> checking, risking NULL pointer dereference or invalid pointer usage.
> 
> Add IS_ERR() checks after these calls and return PTR_ERR()
> on error.

* Can an other word wrapping look eventually a bit nicer here?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18#n658

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18#n145

Regards,
Markus