linux-kernel - Re: [PATCH v5 11/24] KVM: arm64: Writethrough trapped PMEVTYPER register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512110209.GjVZa9ti-lkp@intel.com>
Date: Thu, 11 Dec 2025 02:31:00 +0800
From: kernel test robot <lkp@...el.com>
To: Colton Lewis <coltonlewis@...gle.com>, kvm@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Paolo Bonzini <pbonzini@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Russell King <linux@...linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Marc Zyngier <maz@...nel.org>,
	Oliver Upton <oliver.upton@...ux.dev>,
	Mingwei Zhang <mizhang@...gle.com>, Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Mark Rutland <mark.rutland@....com>,
	Shuah Khan <skhan@...uxfoundation.org>,
	Ganapatrao Kulkarni <gankulkarni@...amperecomputing.com>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
	linux-perf-users@...r.kernel.org, linux-kselftest@...r.kernel.org,
	Colton Lewis <coltonlewis@...gle.com>
Subject: Re: [PATCH v5 11/24] KVM: arm64: Writethrough trapped PMEVTYPER
 register

Hi Colton,

kernel test robot noticed the following build errors:

[auto build test ERROR on ac3fd01e4c1efce8f2c054cdeb2ddd2fc0fb150d]

url:    https://github.com/intel-lab-lkp/linux/commits/Colton-Lewis/arm64-cpufeature-Add-cpucap-for-HPMN0/20251210-055309
base:   ac3fd01e4c1efce8f2c054cdeb2ddd2fc0fb150d
patch link:    https://lore.kernel.org/r/20251209205121.1871534-12-coltonlewis%40google.com
patch subject: [PATCH v5 11/24] KVM: arm64: Writethrough trapped PMEVTYPER register
config: arm64-randconfig-001-20251210 (https://download.01.org/0day-ci/archive/20251211/202512110209.GjVZa9ti-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/202512110209.GjVZa9ti-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512110209.GjVZa9ti-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/arm64/kvm/sys_regs.c: In function 'writethrough_pmevtyper':
>> arch/arm64/kvm/sys_regs.c:1183:34: error: implicit declaration of function 'kvm_pmu_event_mask'; did you mean 'kvm_pmu_evtyper_mask'? [-Wimplicit-function-declaration]
    1183 |                 eventsel = val & kvm_pmu_event_mask(vcpu->kvm);
         |                                  ^~~~~~~~~~~~~~~~~~
         |                                  kvm_pmu_evtyper_mask


vim +1183 arch/arm64/kvm/sys_regs.c

  1168	
  1169	static bool writethrough_pmevtyper(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
  1170					   u64 reg, u64 idx)
  1171	{
  1172		u64 eventsel;
  1173		u64 val = p->regval;
  1174		u64 evtyper_set = ARMV8_PMU_EXCLUDE_EL0 |
  1175			ARMV8_PMU_EXCLUDE_EL1;
  1176		u64 evtyper_clr = ARMV8_PMU_INCLUDE_EL2;
  1177	
  1178		__vcpu_assign_sys_reg(vcpu, reg, val);
  1179	
  1180		if (idx == ARMV8_PMU_CYCLE_IDX)
  1181			eventsel = ARMV8_PMUV3_PERFCTR_CPU_CYCLES;
  1182		else
> 1183			eventsel = val & kvm_pmu_event_mask(vcpu->kvm);
  1184	
  1185		if (vcpu->kvm->arch.pmu_filter &&
  1186		    !test_bit(eventsel, vcpu->kvm->arch.pmu_filter))
  1187			val |= evtyper_set;
  1188	
  1189		val &= ~evtyper_clr;
  1190	
  1191		if (idx == ARMV8_PMU_CYCLE_IDX)
  1192			write_pmccfiltr(val);
  1193		else
  1194			write_pmevtypern(idx, val);
  1195	
  1196		return true;
  1197	}
  1198	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki