linux-kernel - Re: [PATCH v14 0/3] PCI: trace: Add a RAS tracepoint to monitor link speed changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251211003057.GA3553594@bhelgaas>
Date: Wed, 10 Dec 2025 18:30:57 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Shuai Xue <xueshuai@...ux.alibaba.com>
Cc: rostedt@...dmis.org, lukas@...ner.de, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
	mattc@...estorage.com, Jonathan.Cameron@...wei.com,
	alok.a.tiwari@...cle.com, bhelgaas@...gle.com, tony.luck@...el.com,
	bp@...en8.de, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
	oleg@...hat.com, naveen@...nel.org, davem@...emloft.net,
	anil.s.keshavamurthy@...el.com, mark.rutland@....com,
	peterz@...radead.org, tianruidong@...ux.alibaba.com
Subject: Re: [PATCH v14 0/3] PCI: trace: Add a RAS tracepoint to monitor link
 speed changes

On Wed, Dec 10, 2025 at 09:29:04PM +0800, Shuai Xue wrote:
> changes since v13:
> - fix doc typos per ALOK TIWARI
> 
> changes since v12:
> - add Reviewed-by tag for PATCH 1 from Steve
> - add Reviewed-by tag for PATCH 1-3 from Ilpo
> - add comments for why use string to define tracepoint per Steve
> - minor doc improvements from Ilpo
> - remove use pci_speed_string to fix PCI dependends which cause build error on sparc64
> 
> changes since v11:
> - rebase to Linux 6.18-rc1 (no functional changes)
> 
> changes since v10:
> - explicitly include header file per Ilpo
> - add comma on any non-terminator entry  per Ilpo
> - compile trace.o under CONFIG_TRACING per Ilpo
> 
> changes since v9:
> - add a documentation about PCI tracepoints per Bjorn
> - create a dedicated drivers/pci/trace.c that always defines the PCI tracepoints per Steve
> - move tracepoint callite into __pcie_update_link_speed() per Lukas and Bjorn
> 
> changes since v8:
> - rewrite commit log from Bjorn
> - move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
> - rename hotplug event strings per Bjorn and Lukas
> - add PCIe link tracepoint per Bjorn, Lukas, and Ilpo
> 
> changes since v7:
> - replace the TRACE_INCLUDE_PATH to avoid macro conflict per Steven
> - pick up Reviewed-by from Lukas Wunner
> 
> Hotplug events are critical indicators for analyzing hardware health, and
> surprise link downs can significantly impact system performance and reliability.
> In addition, PCIe link speed degradation directly impacts system performance and
> often indicates hardware issues such as faulty devices, physical layer problems,
> or configuration errors.
> 
> This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
> hotplug events and PCIe link speed degradation.
> 
> Shuai Xue (3):
>   PCI: trace: Add a generic RAS tracepoint for hotplug event
>   PCI: trace: Add a RAS tracepoint to monitor link speed changes
>   Documentation: tracing: Add documentation about PCI tracepoints
> 
>  Documentation/trace/events-pci.rst |  74 +++++++++++++++++
>  drivers/pci/Makefile               |   3 +
>  drivers/pci/hotplug/pciehp_ctrl.c  |  31 +++++--
>  drivers/pci/hotplug/pciehp_hpc.c   |   3 +-
>  drivers/pci/pci.c                  |   2 +-
>  drivers/pci/pci.h                  |  21 ++++-
>  drivers/pci/pcie/bwctrl.c          |   4 +-
>  drivers/pci/probe.c                |   9 +-
>  drivers/pci/trace.c                |  11 +++
>  include/trace/events/pci.h         | 129 +++++++++++++++++++++++++++++
>  include/uapi/linux/pci.h           |   7 ++
>  11 files changed, 279 insertions(+), 15 deletions(-)
>  create mode 100644 Documentation/trace/events-pci.rst
>  create mode 100644 drivers/pci/trace.c
>  create mode 100644 include/trace/events/pci.h

Applied to pci/trace for v6.20, thanks!  This will be rebased after
v6.19-rc1.