linux-kernel - Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3699da2-288a-4743-895a-f54daa1a51e7@gmail.com>
Date: Thu, 11 Dec 2025 22:50:35 +0100
From: Christian Schrefl <chrisi.schrefl@...il.com>
To: Gary Guo <gary@...yguo.net>, Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 Fiona Behrens <me@...enk.dev>
Cc: rust-for-linux@...r.kernel.org, Tamir Duberstein <tamird@...il.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and
 quote workarounds

Hi Gary,

On 12/11/25 7:56 PM, Gary Guo wrote:
> From: Benno Lossin <lossin@...nel.org>
> 
> The kernel only had the `proc-macro` library available, whereas the
> user-space version also used `proc-macro2` and `quote`. Now both are
> available to the kernel, making it possible to remove the workarounds.
> 
> Signed-off-by: Benno Lossin <lossin@...nel.org>
> Co-developed-by: Gary Guo <gary@...yguo.net>
> Signed-off-by: Gary Guo <gary@...yguo.net>
> ---

Its good to see some workarounds/hacks get removed!

Overall seems fine, but maybe the imports should be changed to the
multiline kernel style?

Anyways:

Reviewed-by: Christian Schrefl <chrisi.schrefl@...il.com>

Cheers
Christian