linux-kernel - Re: [PATCH 1/9] gpu: nova-core: gsp: warn if data remains after processing a message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d47f7ca5afe8b53f63d91743323d152fe063ba86.camel@redhat.com>
Date: Thu, 11 Dec 2025 16:59:59 -0500
From: lyude@...hat.com
To: Alexandre Courbot <acourbot@...dia.com>, Danilo Krummrich
 <dakr@...nel.org>,  Alice Ryhl <aliceryhl@...gle.com>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: John Hubbard <jhubbard@...dia.com>, Alistair Popple
 <apopple@...dia.com>,  Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi
 <ttabi@...dia.com>, Edwin Peer <epeer@...dia.com>, 
	nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 1/9] gpu: nova-core: gsp: warn if data remains after
 processing a message

Reviewed-by: Lyude Paul <lyude@...hat.com>

On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
> Not processing the whole data from a received message is a strong
> indicator of a bug - emit a warning when such cases are detected.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  drivers/gpu/nova-core/gsp/cmdq.rs | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-
> core/gsp/cmdq.rs
> index dab73377c526..5ce85ee1ffce 100644
> --- a/drivers/gpu/nova-core/gsp/cmdq.rs
> +++ b/drivers/gpu/nova-core/gsp/cmdq.rs
> @@ -662,7 +662,17 @@ pub(crate) fn receive_msg<M:
> MessageFromGsp>(&mut self, timeout: Delta) -> Resul
>              let (cmd, contents_1) =
> M::Message::from_bytes_prefix(message.contents.0).ok_or(EIO)?;
>              let mut sbuffer = SBufferIter::new_reader([contents_1,
> message.contents.1]);
>  
> -            M::read(cmd, &mut sbuffer).map_err(|e| e.into())
> +            let res = M::read(cmd, &mut sbuffer).map_err(|e|
> e.into());
> +
> +            if res.is_ok() && !sbuffer.is_empty() {
> +                dev_warn!(
> +                    &self.dev,
> +                    "GSP message {:?} has unprocessed data\n",
> +                    function
> +                );
> +            }
> +
> +            res
>          } else {
>              Err(ERANGE)
>          };