linux-kernel - Re: [PATCH] crypto: scompress - Use crypto_unregister_scomps in crypto_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTo16OvI0ffoHZV2@gondor.apana.org.au>
Date: Thu, 11 Dec 2025 11:09:28 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: scompress - Use crypto_unregister_scomps in
 crypto_register_scomps

On Wed, Dec 10, 2025 at 02:25:48PM +0100, Thorsten Blum wrote:
> Define crypto_unregister_scomps() before crypto_register_scomps() and
> replace the for loop with a call to crypto_unregister_scomps().  Return
> 'ret' immediately and remove the goto statement to simplify the error
> handling code.  No functional changes.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  crypto/scompress.c | 30 +++++++++++++-----------------
>  1 file changed, 13 insertions(+), 17 deletions(-)
> 
> diff --git a/crypto/scompress.c b/crypto/scompress.c
> index 1a7ed8ae65b0..3e026a6eefe8 100644
> --- a/crypto/scompress.c
> +++ b/crypto/scompress.c
> @@ -377,34 +377,30 @@ void crypto_unregister_scomp(struct scomp_alg *alg)
>  }
>  EXPORT_SYMBOL_GPL(crypto_unregister_scomp);
>  
> +void crypto_unregister_scomps(struct scomp_alg *algs, int count)
> +{
> +	int i;
> +
> +	for (i = count - 1; i >= 0; --i)
> +		crypto_unregister_scomp(&algs[i]);
> +}
> +EXPORT_SYMBOL_GPL(crypto_unregister_scomps);

There is no need to move this function.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt