linux-kernel - Re: [PATCH] Removed unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTpdYqy0Q5gGfr3p@raspberrypi>
Date: Thu, 11 Dec 2025 06:57:54 +0100
From: Pycode <pycode42@...il.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Removed unused variable

On Thu, Dec 11, 2025 at 08:10:25AM +0900, Jeff Layton wrote:
> A more descriptive title is preferred: "Remove unused variable from
> nfs4_ff_alloc_deviceid_node()"
> 

Thanks for the advices!

> On Wed, 2025-12-10 at 21:59 +0100, Pycode wrote:
> > Signed-off-by: Pycode <pycode42@...il.com>
> > 
> > Removed the unused variable ret in
> > fs/nfs/flexfilelayout/flexfilelayoutdev.c
> > 
> > (Disclaimer this is my first patch, be sorry if I have done anything
> > wrong!)
> > ---
> >  fs/nfs/flexfilelayout/flexfilelayoutdev.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/fs/nfs/flexfilelayout/flexfilelayoutdev.c b/fs/nfs/flexfilelayout/flexfilelayoutdev.c
> > index c55ea8fa3bfa..9cd04e85d52f 100644
> > --- a/fs/nfs/flexfilelayout/flexfilelayoutdev.c
> > +++ b/fs/nfs/flexfilelayout/flexfilelayoutdev.c
> > @@ -53,7 +53,7 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev,
> >  	u32 mp_count;
> >  	u32 version_count;
> >  	__be32 *p;
> > -	int i, ret = -ENOMEM;
> > +	int i = -ENOMEM;
> >  
> 
> No need to initialize this.
> 
> >  	/* set up xdr stream */
> >  	scratch = folio_alloc(gfp_flags, 0);
> > @@ -88,7 +88,6 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev,
> >  	if (list_empty(&dsaddrs)) {
> >  		dprintk("%s: no suitable DS addresses found\n",
> >  			__func__);
> > -		ret = -ENOMEDIUM;
> >  		goto out_err_drain_dsaddrs;
> >  	}
> >  
> > @@ -134,7 +133,6 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, struct pnfs_device *pdev,
> >  			dprintk("%s: [%d] unsupported ds version %d-%d\n", __func__,
> >  				i, ds_versions[i].version,
> >  				ds_versions[i].minor_version);
> > -			ret = -EPROTONOSUPPORT;
> >  			goto out_err_drain_dsaddrs;
> >  		}
> >  
> 
> What about the dprintk() at the bottom of this function? Does this
> actually build?

There is no dprintk() at the bottom that used the variable.

> 
> -- 
> Jeff Layton <jlayton@...nel.org>