linux-kernel - Re: [PATCH 3/8] selftests: ublk: fix fio arguments in run_io_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTqI-SzV2uS9YPQ5@fedora>
Date: Thu, 11 Dec 2025 17:03:53 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Shuah Khan <shuah@...nel.org>, linux-block@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] selftests: ublk: fix fio arguments in
 run_io_and_recover()

On Wed, Dec 10, 2025 at 10:15:58PM -0700, Caleb Sander Mateos wrote:
> run_io_and_recover() invokes fio with --size="${size}", but the variable
> size doesn't exist. Thus, the argument expands to --size=, which causes
> fio to exit immediately with an error without issuing any I/O. Pass the
> value for size as the first argument to the function.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming