| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <dbd4c202-5be9-4f18-9413-5c5e50d3db88@linaro.org>
Date: Thu, 11 Dec 2025 13:09:36 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>, robh@...nel.org,
krzk+dt@...nel.org, sakari.ailus@...ux.intel.com
Cc: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...nel.org>,
Hans de Goede <hansg@...nel.org>, Mehdi Djait <mehdi.djait@...ux.intel.com>,
André Apitzsch <git@...tzsch.eu>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Dongcheng Yan <dongcheng.yan@...el.com>,
Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
Sylvain Petinot <sylvain.petinot@...s.st.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Jingjing Xiong <jingjing.xiong@...el.com>,
Svyatoslav Ryhel <clamor95@...il.com>,
Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add os05b10 sensor
On 12/11/25 12:54, Himanshu Bhavani wrote:
> From: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
>
> Add bindings for Omnivision OS05B10 sensor.
>
> Add MAINTAINERS entry for Omnivision OS05B10 binding documentation
>
> Signed-off-by: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> ---
> .../bindings/media/i2c/ovti,os05b10.yaml | 103 ++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,os05b10.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,os05b10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,os05b10.yaml
> new file mode 100644
> index 000000000000..b16e5333b1ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,os05b10.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ovti,os05b10.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OmniVision OS05B10 Image Sensor
> +
> +maintainers:
> + - Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
> +
> +description:
> + The OmniVision OS05B10 is a 5MP (2592x1944) color CMOS image sensor controlled
> + through an I2C-compatible SCCB bus. it outputs RAW10/RAW12 format and uses a
> + 1/2.78"optical format.
A space symbol is missing before 'optical'.
> +
> +properties:
> + compatible:
> + const: ovti,os05b10
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: XCLK clock
> +
> + avdd-supply:
> + description: Analog Domain Power Supply
> +
> + dovdd-supply:
> + description: I/O Domain Power Supply
> +
> + dvdd-supply:
> + description: Digital Domain Power Supply
> +
> + reset-gpios:
> + maxItems: 1
> + description: Reset Pin GPIO Control (active high)
If you have access to datasheet, what does it say about the reset GPIO?
It's very uncommon to see an active high GPIO here, most likely it
shoud be changed to active low.
> +
> + port:
> + description: MIPI CSI-2 transmitter port
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - items:
> + - const: 1
> + - const: 2
> + required:
> + - data-lanes
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - avdd-supply
> + - dovdd-supply
> + - dvdd-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera-sensor@36 {
> + compatible = "ovti,os05b10";
> + reg = <0x36>;
> + clocks = <&os05b10_clk>;
> + reset-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> +
> + avdd-supply = <&os05b10_avdd_2v8>;
> + dvdd-supply = <&os05b10_dvdd_1v2>;
> + dovdd-supply = <&os05b10_dovdd_1v8>;
> +
> + port {
> + cam_out: endpoint {
> + remote-endpoint = <&mipi_in_cam>;
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <600000000>;
> + };
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 663e86eb9ff1..c85915d5d20e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19234,6 +19234,13 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/ovti,og0ve1b.yaml
> F: drivers/media/i2c/og0ve1b.c
>
> +OMNIVISION OS05B10 SENSOR DRIVER
> +M: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
> +M: Elgin Perumbilly <elgin.perumbilly@...iconsignals.io>
> +L: linux-media@...r.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/ovti,os05b10.yaml
> +
> OMNIVISION OV01A10 SENSOR DRIVER
> M: Bingbu Cao <bingbu.cao@...el.com>
> L: linux-media@...r.kernel.org
--
Best wishes,
Vladimir
Powered by blists - more mailing lists