linux-kernel - Re: [PATCH] ACPI: PCC: Fix race condition by removing static qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8caaea8-7c47-4b3c-a80c-2a9b144ffd98@huawei.com>
Date: Thu, 11 Dec 2025 09:35:24 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Sudeep Holla <sudeep.holla@....com>, Pengjie Zhang
	<zhangpengjie2@...wei.com>
CC: <rafael@...nel.org>, <lenb@...nel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <zhanjie9@...ilicon.com>,
	<zhenglifeng1@...wei.com>, <yubowen8@...wei.com>, <linhongye@...artners.com>,
	<linuxarm@...wei.com>, <jonathan.cameron@...wei.com>, <wangzhi12@...wei.com>
Subject: Re: [PATCH] ACPI: PCC: Fix race condition by removing static
 qualifier


在 2025/12/10 22:54, Sudeep Holla 写道:
> On Wed, Dec 10, 2025 at 09:26:34PM +0800, Pengjie Zhang wrote:
>> The variable 'ret' in acpi_pcc_address_space_setup() is currently
>> declared with the 'static' storage specifier. This can lead to race
>> conditions in a multithreaded environment.
>>
>> Remove the 'static' qualifier to ensure 'ret' is allocated directly
>> on the stack as a local variable.
>>
> Ah, my mistake. I’m not sure how that slipped in other than a simple typo or
> copy/paste error. Thanks for catching it. Let me know if you spotted it
> because something broke or just from reading the code.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
Acked-by: lihuisong@...wei.com
>