linux-kernel - Re: [PATCH] usb: typec: altmodes/displayport: Drop the device reference in dp_altmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTrKNrvXX1gZ49cS@kuha>
Date: Thu, 11 Dec 2025 15:42:14 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: gregkh@...uxfoundation.org, rdbabiera@...gle.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] usb: typec: altmodes/displayport: Drop the device
 reference in dp_altmode_probe()

Sat, Dec 06, 2025 at 03:04:45PM +0800, Haoxiang Li kirjoitti:
> In error paths, call typec_altmode_put_plug() to drop the device reference
> obtained by typec_altmode_get_plug().
> 
> Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/altmodes/displayport.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index 1dcb77faf85d..5d02c97e256e 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -764,12 +764,16 @@ int dp_altmode_probe(struct typec_altmode *alt)
>  	if (!(DP_CAP_PIN_ASSIGN_DFP_D(port->vdo) &
>  	      DP_CAP_PIN_ASSIGN_UFP_D(alt->vdo)) &&
>  	    !(DP_CAP_PIN_ASSIGN_UFP_D(port->vdo) &
> -	      DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo)))
> -		return -ENODEV;
> +	      DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo))) {
> +		typec_altmode_put_plug(plug);
> +		return -ENODEV;
> +	}
>  
>  	dp = devm_kzalloc(&alt->dev, sizeof(*dp), GFP_KERNEL);
> -	if (!dp)
> +	if (!dp) {
> +		typec_altmode_put_plug(plug);
>  		return -ENOMEM;
> +	}
>  
>  	INIT_WORK(&dp->work, dp_altmode_work);
>  	mutex_init(&dp->lock);
> -- 
> 2.25.1

-- 
heikki