linux-kernel - Re: [PATCH] ksmbd: remove redundant DACL check in smb_check_perm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-fadJV1vJrKMyDwJ9=Mho50vU5VM1uhBYGq6pY99boTQ@mail.gmail.com>
Date: Thu, 11 Dec 2025 10:37:48 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Alexey Velichayshiy <a.velichayshiy@...ras.ru>
Cc: Steve French <smfrench@...il.com>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] ksmbd: remove redundant DACL check in smb_check_perm_dacl

On Wed, Dec 10, 2025 at 10:52 PM Alexey Velichayshiy
<a.velichayshiy@...ras.ru> wrote:
>
> A zero value of pdacl->num_aces is already handled at the start of
> smb_check_perm_dacl() so the second check is useless.
>
> Drop the unreachable code block, no functional impact intended.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexey Velichayshiy <a.velichayshiy@...ras.ru>
Applied it to #ksmbd-for-next-next.
Thanks!