linux-kernel - Re: [PATCH v1 1/1] leds: Unexport of_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTrLS84EjEGuSXC1@smile.fi.intel.com>
Date: Thu, 11 Dec 2025 15:46:51 +0200
From: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
To: Jonathan Brophy <J.Brophy@...killsystems.co.nz>,
	"lee@...nel.org" <lee@...nel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	Pavel Machek <pavel@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] leds: Unexport of_led_get()

On Thu, Dec 11, 2025 at 01:34:10PM +0100, Alexander Dahl wrote:
> Am Wed, Dec 10, 2025 at 11:54:19PM +0200 schrieb andriy.shevchenko@...ux.intel.com:
> > On Wed, Dec 10, 2025 at 06:30:06PM +0000, Jonathan Brophy wrote:
> > > > Can you elaborate? I think your downstream code (I have no other ideas where you Q came from)
> > > > uses some outdated approaches. Try to look at the problem from the level of the existing APIs and 
> > > > frameworks. We shouldn't really have such an issue (but it might be some special use case, I admit).
> > > 
> > > I'm trying to create a virtual led driver but with the removal of
> > > of_led_get() im struggling to find a way to make it work.
> > 
> > Still it's unclear to me what it means and how the code look like.
> > Perhaps you need to send some patches for the discussion (maybe as
> > RFC if you think they are not upstream ready).
> 
> I guess it is about the patch series Jonathan already sent?

I don't know, I wasn't in Cc list there. And it seems the series got a lot of
useful comments already. So. if next version being Cc'ed to me, I would review
it. (Going ahead: the series, if survives the approach, has a lot of style and
related mistakes, like wrong kernel version and data in the ABI documentation.)

> https://lore.kernel.org/linux-leds/20251019092331.49531-1-professorjonny98@gmail.com/T/#u


-- 
With Best Regards,
Andy Shevchenko