linux-kernel - [PATCH v2 0/7] smb: move duplicate definitions into common header file, part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251211143228.172470-1-chenxiaosong.chenxiaosong@linux.dev>
Date: Thu, 11 Dec 2025 22:32:21 +0800
From: chenxiaosong.chenxiaosong@...ux.dev
To: sfrench@...ba.org,
	smfrench@...il.com,
	linkinjeon@...nel.org,
	linkinjeon@...ba.org
Cc: linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: [PATCH v2 0/7] smb: move duplicate definitions into common header file, part 2

From: ChenXiaoSong <chenxiaosong@...inos.cn>

For more detailed information about the patches to be reviewed, please see the link:
https://chenxiaosong.com/en/smb-patch.html

This is a continuous effort to move duplicated definitions in both client
and server into common header files, which makes the code easier to maintain.

The previous work is here:
part 1: https://lore.kernel.org/linux-cifs/20251117112838.473051-1-chenxiaosong.chenxiaosong@linux.dev/

v1: https://lore.kernel.org/all/20251209011020.3270989-1-chenxiaosong.chenxiaosong@linux.dev/
The following patches from v1 have already been merged into cifs-2.6.git for-next and ksmbd.git ksmbd-for-next:
  - smb/server: add comment to FileSystemName of FileFsAttributeInformation
  - smb/client: remove DeviceType Flags and Device Characteristics definitions
  - smb: move file_notify_information to common/fscc.h
  - smb: move SMB2 Notify Action Flags into common/smb2pdu.h
  - smb: move notify completion filter flags into common/smb2pdu.h
  - smb: add documentation references for smb2 change notify definitions

The following patches from this version(v2) have already been merged into cifs-2.6.git for-next:
  - smb: move some SMB1 definitions into common/smb1pdu.h
  - smb: move File Attributes definitions into common/fscc.h
  - smb: update struct duplicate_extents_to_file_ex

v1->v2:
  - Patch #0001: update FILE_ATTRIBUTE_MASK value
  - Patch #0002: `__u64 StructureSize` -> `__le64 StructureSize`
  - Patch #0003: conflicts have been resolved

ChenXiaoSong (2):
  smb: move File Attributes definitions into common/fscc.h
  smb: update struct duplicate_extents_to_file_ex

ZhangGuoDong (5):
  smb: move some SMB1 definitions into common/smb1pdu.h
  smb: move smb3_fs_vol_info into common/fscc.h
  smb: move some definitions from common/smb2pdu.h into common/fscc.h
  smb: introduce struct create_posix_ctxt_rsp
  smb: introduce struct file_posix_info

 fs/smb/client/cifspdu.h    |   2 +-
 fs/smb/client/inode.c      |  22 +-
 fs/smb/client/readdir.c    |  28 +--
 fs/smb/client/reparse.h    |   4 +-
 fs/smb/client/smb2pdu.c    |   9 +-
 fs/smb/client/smb2pdu.h    |  21 +-
 fs/smb/common/fscc.h       | 415 ++++++++++++++++++++++++++++++++++-
 fs/smb/common/smb1pdu.h    |  56 +++++
 fs/smb/common/smb2pdu.h    | 432 ++-----------------------------------
 fs/smb/common/smbglob.h    |   2 -
 fs/smb/server/oplock.c     |   8 +-
 fs/smb/server/smb2pdu.c    |  84 ++++----
 fs/smb/server/smb2pdu.h    |  27 +--
 fs/smb/server/smb_common.h |   9 +-
 14 files changed, 572 insertions(+), 547 deletions(-)
 create mode 100644 fs/smb/common/smb1pdu.h

-- 
2.43.0