linux-kernel - Re: Re: [PATCH v7 2/3] PCI: eic7700: Add Eswin PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251211160752.GA3594705@bhelgaas>
Date: Thu, 11 Dec 2025 10:07:52 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: zhangsenchuan <zhangsenchuan@...incomputing.com>
Cc: bhelgaas@...gle.com, mani@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, lpieralisi@...nel.org, kwilczynski@...nel.org,
	robh@...nel.org, p.zabel@...gutronix.de, jingoohan1@...il.com,
	gustavo.pimentel@...opsys.com, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	christian.bruel@...s.st.com, mayank.rana@....qualcomm.com,
	shradha.t@...sung.com, krishna.chundru@....qualcomm.com,
	thippeswamy.havalige@....com, inochiama@...il.com, Frank.li@....com,
	ningyu@...incomputing.com, linmin@...incomputing.com,
	pinkesh.vaghela@...fochips.com, ouyanghui@...incomputing.com
Subject: Re: Re: [PATCH v7 2/3] PCI: eic7700: Add Eswin PCIe host controller
 driver

On Thu, Dec 11, 2025 at 08:05:19PM +0800, zhangsenchuan wrote:
> > -----Original Messages-----
> > From: "Bjorn Helgaas" <helgaas@...nel.org>
> > Send time:Thursday, 11/12/2025 00:43:27
> > To: zhangsenchuan@...incomputing.com
> > Cc: bhelgaas@...gle.com, mani@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, lpieralisi@...nel.org, kwilczynski@...nel.org, robh@...nel.org, p.zabel@...gutronix.de, jingoohan1@...il.com, gustavo.pimentel@...opsys.com, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, christian.bruel@...s.st.com, mayank.rana@....qualcomm.com, shradha.t@...sung.com, krishna.chundru@....qualcomm.com, thippeswamy.havalige@....com, inochiama@...il.com, Frank.li@....com, ningyu@...incomputing.com, linmin@...incomputing.com, pinkesh.vaghela@...fochips.com, ouyanghui@...incomputing.com
> > Subject: Re: [PATCH v7 2/3] PCI: eic7700: Add Eswin PCIe host controller driver

Please avoid the pointless quote of all the headers (above) if you
can.  That just clutters the thread.  Also trim context that is not
relevant.  More hints here: https://subspace.kernel.org/etiquette.html

> > On Tue, Dec 02, 2025 at 05:04:06PM +0800, zhangsenchuan@...incomputing.com wrote:
> > > From: Senchuan Zhang <zhangsenchuan@...incomputing.com>
> > > 
> > > Add driver for the Eswin EIC7700 PCIe host controller, which is based on
> > > the DesignWare PCIe core, IP revision 5.96a. The PCIe Gen.3 controller
> > > supports a data rate of 8 GT/s and 4 channels, support INTx and MSI
> > > interrupts.

> > > +static int eic7700_pcie_probe(struct platform_device *pdev)
> > > ...
> > > +	pci->no_pme_handshake = pcie->data->no_pme_handshake;
> > 
> > This needs to go in the 3/3 "PCI: dwc: Add no_pme_handshake flag and
> > skip PME_Turn_Off broadcast" patch because "no_pme_handshake" doesn't
> > exist yet so this patch doesn't build by itself.
> 
> Do I need to adjust the order of the patches?
> 3/2 "PCI: dwc: Add no_pme_handshake flag and skip PME_Turn_Off broadcast"
> 3/3 "PCI: eic7700: Add Eswin PCIe host controller driver"
> 
> Or merge Patch 2/3 and Patch 3/3?

I think the best thing would be to leave dw_pcie_suspend_noirq() along
and implement eic7700_pcie_suspend_noirq() without calling it.

dw_pcie_suspend_noirq() is already problematic [1], and we don't need
more complication there.  Even without calling
dw_pcie_suspend_noirq(), your eic7700_pcie_suspend_noirq() will be
pretty simple.  Just add a comment about why you don't use
dw_pcie_suspend_noirq().

[1] https://lore.kernel.org/linux-pci/20251114213540.GA2335845@bhelgaas/