linux-kernel - Re: [PATCH v7 17/20] media: platform: mtk-mdp3: Use cmdq_pkt_jump_rel() without shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8270743bbea41ec9fe7d694908ec0c677ed7ba09.camel@mediatek.com>
Date: Thu, 11 Dec 2025 17:34:52 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, "robh@...nel.org"
	<robh@...nel.org>, "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"fshao@...omium.org" <fshao@...omium.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"wenst@...omium.org" <wenst@...omium.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>
Subject: Re: [PATCH v7 17/20] media: platform: mtk-mdp3: Use
 cmdq_pkt_jump_rel() without shift_pa

Hi Nicolas,

On Tue, 2025-12-09 at 16:01 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> Le mercredi 27 août 2025 à 19:37 +0800, Jason-JH Lin a écrit :
> > With the removal of the shift_pa parameter,
> > cmdq_pkt_jump_rel_temp()
> > can be replaced by the new cmdq_pkt_jump_rel() without shift_pa.
> > 
> > Then, remove the cmdq_shift_pa variable in the mdp_dev structure
> > for
> > each mbox client.
> > 
> > Fixes: ade176534112 ("soc: mediatek: cmdq: Add parameter shift_pa
> > to cmdq_pkt_jump()")
> > Signed-off-by: Jason-JH Lin <jason-jh.lin@...iatek.com>
> > ---
> >  drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 2 +-
> >  drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 2 --
> >  drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h | 1 -
> >  3 files changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > index 7575ec376367..c35fe0e3a4d5 100644
> > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > @@ -638,7 +638,7 @@ static struct mdp_cmdq_cmd
> > *mdp_cmdq_prepare(struct mdp_dev *mdp,
> >  		goto err_free_path;
> >  	}
> >  	cmdq_pkt_eoc(&cmd->pkt);
> > -	cmdq_pkt_jump_rel_temp(&cmd->pkt, CMDQ_INST_SIZE, mdp-
> > >cmdq_shift_pa[pp_idx]);
> > +	cmdq_pkt_jump_rel(&cmd->pkt, CMDQ_INST_SIZE);
> 
> That effectively revert another patch that is pending, and remove the
> use of the
> new cmdq_pkt_jump_rel_temp(). I don't follow what is doing on here, I
> think some
> context must be lost.
> 

Please forget about this patch. I separated this series to 5 different
series.

Please refer to series application order:
1. [Fixes] Refine DMA address handling for the command buffer
https://lore.kernel.org/all/20251022171847.379470-1-jason-jh.lin@mediatek.com/
2. [Series 1/4] Add GCE support for MT8196 and update CMDQ APIs
https://lore.kernel.org/all/20251031155838.1650833-1-jason-jh.lin@mediatek.com/
3. [Series 2/4] Migrate subsystems to new CMDQ APIs
https://lore.kernel.org/all/20251031160309.1654761-1-jason-jh.lin@mediatek.com/
4. [Series 3/4] Remove shift_pa from CMDQ jump functions
https://lore.kernel.org/all/20251031160712.1657810-1-jason-jh.lin@mediatek.com/
5. [Series 4/4] Remove deprecated CMDQ APIs 
https://lore.kernel.org/all/20251031160955.1659524-1-jason-jh.lin@mediatek.com/

Thanks!

Regards,
Jason-JH Lin

> Nicolas