linux-kernel - Re: [PATCH net-next v7 4/9] net: let pp memory provider to specify rx buf len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251213085713.087c028e@kernel.org>
Date: Sat, 13 Dec 2025 08:57:13 +0900
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan
 Corbet <corbet@....net>, Michael Chan <michael.chan@...adcom.com>, Pavan
 Chebbi <pavan.chebbi@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John
 Fastabend <john.fastabend@...il.com>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>, Shuah Khan <shuah@...nel.org>, Mina Almasry
 <almasrymina@...gle.com>, Stanislav Fomichev <sdf@...ichev.me>, Yue Haibing
 <yuehaibing@...wei.com>, David Wei <dw@...idwei.uk>, Haiyue Wang
 <haiyuewa@....com>, Jens Axboe <axboe@...nel.dk>, Joe Damato
 <jdamato@...tly.com>, Simon Horman <horms@...nel.org>, Vishwanath Seshagiri
 <vishs@...com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 io-uring@...r.kernel.org, dtatulea@...dia.com
Subject: Re: [PATCH net-next v7 4/9] net: let pp memory provider to specify
 rx buf len

On Thu, 11 Dec 2025 01:31:09 +0000 Pavel Begunkov wrote:
> > Also RX_PAGE_SIZE is a better name for the fields? RX_BUF_SIZE
> > is easy to confuse with RX_BUF_LEN which we are no longer trying
> > to modify.  
> 
> It's not "page" because there are no struct page's, and those are
> just buffers. Maybe it's also some net/driver specific term?
> I don't get the difference here b/w "size" and "len" either, but
> in any case I don't really have any real opinion about the name,
> and it can always be changed later.

RX_BUF_LEN is the existing config options which we were trying to use
initially. We're not following that approach any more. The thinking
about page is that we're replacing the device pages (rather than host
struct page), in bnxt we're replacing a define called
BNXT_RX_PAGE_SIZE. I suspect we'd be doing a similar replacement
in most drivers, replace some define / math they have based on PAGE_SIZE